Closed Bug 883629 Opened 6 years ago Closed 6 years ago

remove test pilot from thunderbird

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird24+ fixed)

RESOLVED FIXED
Thunderbird 24.0
Tracking Status
thunderbird24 + fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch proposed fix (obsolete) — Splinter Review
Testpilot got removed from firefox in bug 867445.
We don't necessarily have to, see bug 867437 comment 3, but following ff usually is the best  thing to do.

Sent to try - https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=bcb6c804faa9
Attachment #763222 - Flags: review?(mbanner)
Comment on attachment 763222 [details] [diff] [review]
proposed fix

Review of attachment 763222 [details] [diff] [review]:
-----------------------------------------------------------------

We also should remove:

/mail/locales/en-US/feedback/main.dtd and /mail/locales/en-US/feedback/main.properties

and adjust mail/locales/jar.mn accordingly, and there's also a extensions.testpilot.lastversion in Mozmill's runtest.py that we should drop.

::: mail/installer/package-manifest.in
@@ -220,5 @@
>  @BINPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/install.rdf
>  @BINPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/icon.png
>  @BINPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png
>  @BINPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest
> -@BINPATH@/distribution/extensions/tbtestpilot@labs.mozilla.com.xpi

This should be added to removed-files.in
Attachment #763222 - Flags: review?(mbanner) → review-
(In reply to Mark Banner (:standard8) from comment #1)
> Comment on attachment 763222 [details] [diff] [review]
> proposed fix
> 
> Review of attachment 763222 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We also should remove:
> 
> /mail/locales/en-US/feedback/main.dtd and
> /mail/locales/en-US/feedback/main.properties
> 
> and adjust mail/locales/jar.mn accordingly, and there's also a
> extensions.testpilot.lastversion in Mozmill's runtest.py that we should drop.

The patch does all these already, no?
Attached patch proposed fix, v2Splinter Review
Added the removed-files.in removal. The other stuff was handled already.
Attachment #763222 - Attachment is obsolete: true
Attachment #764988 - Flags: review?(mbanner)
(In reply to Magnus Melin from comment #3)
> Created attachment 764988 [details] [diff] [review]
> proposed fix, v2
> 
> Added the removed-files.in removal. The other stuff was handled already.

Could I ask you to also remove the mail/app/profile/extensions directory as well?
Wouldn't that be covered by http://mxr.mozilla.org/comm-central/source/mail/installer/removed-files.in#153
If not, i don't know, and it's probably better to do it in another bug. It's not relate, right?
Comment on attachment 764988 [details] [diff] [review]
proposed fix, v2

Review of attachment 764988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I think I missed those extra bits.

Re removing the extensions directory, this patch leaves it just the same as FF at the moment. I'm not against removing it (never did really like app/profile etc in the first place), but I tihnk we should do that in a separate bug.
Attachment #764988 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/374d30ca7c59 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Blocks: 961143
You need to log in before you can comment on or make changes to this bug.