883679 - Building Firefox with MOZ_SERVICES_SYNC undefined doesn't work

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I attempted to build a version of Firefox without sync support, and got the following build error:

make.py[4]: Entering directory 'e:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\browser\locales\../../services/sync/locales'
No makefile found
e:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\browser\locales\Makefile:142:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/try-w32-0000000000000000000000/build/build/pymake/pymake/../make.py -C ../../services/sync/locales AB_CD=en-US XPI_NAME=locale-en-US' failed, return code 2
e:\builds\moz2_slave\try-w32-0000000000000000000000\build\obj-firefox\browser\installer\Makefile:126:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/try-w32-0000000000000000000000/build/build/pymake/pymake/../make.py -C ../../browser/locales langpack' failed, return code 2
e:\builds\moz2_slave\try-w32-0000000000000000000000\build\config\rules.mk:680:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/try-w32-0000000000000000000000/build/build/pymake/pymake/../make.py libs' failed, return code 2
e:\builds\moz2_slave\try-w32-0000000000000000000000\build\browser\build.mk:9:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/try-w32-0000000000000000000000/build/build/pymake/pymake/../make.py -C browser/installer' failed, return code 2
program finished with exit code 2
elapsedTime=93.741000

This is because browser/locales/Makefile.in assumes ../../services/sync/locales will exist.

Patch to fix this problem coming up.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Phil, are you the right person to review this?

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 763288 [details] [diff] [review]
Patch v1

Not at all the right person, but there are times when I don't let that bother me.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Here's the error I'm getting when I run a build with this patch:

XML Parsing Error: undefined entity
Location: chrome://browser/content/browser.xul Line Number 242, Column 5: <broadcaster id="devtoolsMenuBroadcaster_ChromeDebugger" ----^

Sounds like a locale issue, but I don't really have the time to track this down, which is why I'm going for the spit and duct-tape solution in bug 883268.

Comment 4

[James Bonacci [:jbonacci]]

Seems like you want some Sync people involved in this, so I added some...

Comment 5

[Lina Butler (ex-Mozilla)]

I don't think this is a supported configuration anymore. Mike, please reopen if you'd still like to see this land.