Closed Bug 883687 Opened 7 years ago Closed 7 years ago

'Found unexpected crash dump' message should give a proper URL

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: nrc, Assigned: nrc)

Details

Attachments

(1 file, 1 obsolete file)

We seem to be missing '://'
Attached patch fix (obsolete) — Splinter Review
Attachment #763298 - Flags: review?(dbaron)
Oh, I wasn't sure if this was a typo in a message about 'dump's or the message was meant to be about 'dump file's, but it the output looks inconsistent with other messages. For example,

REFTEST TEST-UNEXPECTED-FAIL | file:///home/ncameron/hdd2/firefox/src/layout/reftests/bugs/598726-1.html | This test left crash dumps behind, but we weren't expecting it to!
REFTEST INFO | Found unexpected crash dump file/home/ncameron/.mozilla/firefox/dn680ywa.dev/minidumps/7b8d3dd6-cf79-a15d-169f7993-1cf3f06f.dmp.
REFTEST TEST-LOAD | file:///home/ncameron/hdd2/firefox/src/layout/reftests/bugs/598726-1-ref.html | 0 / 1 (0%)
REFTEST INFO | START file:///home/ncameron/hdd2/firefox/src/layout/reftests/bugs/598726-1-ref.html
I think I intended to just print out the file name, rather than turn it into a file: URL, i.e. I think I just forgot a space at the end of the string.
(In reply to Cameron McCormack (:heycam) from comment #3)
> I think I intended to just print out the file name, rather than turn it into
> a file: URL, i.e. I think I just forgot a space at the end of the string.

Yeah, on second thoughts, my patch does not make sense when run on the server rather than locally. However, it would still be nice to have a URL here, like we do in the other messages. I don't suppose that is too hard.
Attachment #763298 - Attachment is obsolete: true
Attachment #763298 - Flags: review?(dbaron)
Attached patch patchSplinter Review
I couldn't see an obvious way to turn the file into a url, and not sure its really worth any time to worry about it, so here is just an extra space to make it easier to read :-)
Attachment #763478 - Flags: review?(cam)
Comment on attachment 763478 [details] [diff] [review]
patch

r=me
Attachment #763478 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/928202d898e7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.