Closed
Bug 883696
Opened 8 years ago
Closed 8 years ago
Include full paths in all #include statements
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: [js:t])
Attachments
(4 files)
95.39 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
37.78 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
44.56 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
29.43 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
For example, |#include "ion/Ion.h"|, not "#include "Ion.h"|
![]() |
Assignee | |
Updated•8 years ago
|
![]() |
Assignee | |
Comment 1•8 years ago
|
||
This will make writing the header hygiene checker script in bug 880088 easier, because all #include statements will be in a consistent form.
![]() |
Assignee | |
Comment 2•8 years ago
|
||
This patch changes all the #includes in js/src/ion/ to be full paths, e.g. ion/Ion.h instead of just Ion.h. It's very tedious, adding "ion/" or "ion/shared/" or "ion/$PLATFORM" in lots of places, with the following exceptions. - jitprofiling.h doesn't exist, so I removed the relevant #include statements from AsmJS.cpp and AsmJSLink.cpp - I removed the unnecessary |#include "prthread.h"| from IonBuilder.cpp. - I removed the unnecessary |#include "Platform.h"| from RangeAnalysis.h. - I changed |#include <mozilla/StandardInteger.h>| to the correct |#include "mozilla/StandardInteger.h"| in Architecture-arm.cpp. I deliberately didn't change the ordering of any #includes (even though we have plenty of bad orderings) to keep things simple. That can be done later, in another bug.
Attachment #768170 -
Flags: review?(jdemooij)
![]() |
Assignee | |
Comment 3•8 years ago
|
||
This patch is like the previous one, but for js/src/assembler/ and js/src/yarr. Non-trivial changes: - Removed the -I flags for assembler/ and yarr/, since they're no longer needed. - Removed dead "methodjit/Logging.h" from MIPSAssembler.h and SparcAssembler.h. - Removed dead "assembler/wtf/Vector.h" from ARMv7Assembler.h. - Commented out #include "GTypedefs.h" in an unused section of Platform.h. - I changed a bunch of local includes that erroneously used the <> form to the "" form. - I changed |#include "windows.h"| to |#include <windows.h>| in OSAllocatorWin.cpp.
Attachment #768171 -
Flags: review?(luke)
![]() |
Assignee | |
Comment 4•8 years ago
|
||
This one is trivial; every change is the same.
Attachment #768172 -
Flags: review?(luke)
![]() |
Assignee | |
Comment 5•8 years ago
|
||
This one's a hodge-podge.
Attachment #768173 -
Flags: review?(luke)
Comment 6•8 years ago
|
||
Comment on attachment 768170 [details] [diff] [review] (part 1) - Include full paths in #include statements in js/src/ion/. Review of attachment 768170 [details] [diff] [review]: ----------------------------------------------------------------- Very nice, thanks!
Attachment #768170 -
Flags: review?(jdemooij) → review+
![]() |
||
Updated•8 years ago
|
Attachment #768171 -
Flags: review?(luke) → review+
![]() |
||
Updated•8 years ago
|
Attachment #768172 -
Flags: review?(luke) → review+
![]() |
||
Updated•8 years ago
|
Attachment #768173 -
Flags: review?(luke) → review+
![]() |
Assignee | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/41ab7286a2e2 https://hg.mozilla.org/integration/mozilla-inbound/rev/7e729e2c3822 https://hg.mozilla.org/integration/mozilla-inbound/rev/634b48dc2f06 https://hg.mozilla.org/integration/mozilla-inbound/rev/699228670afb
Comment 8•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/41ab7286a2e2 https://hg.mozilla.org/mozilla-central/rev/7e729e2c3822 https://hg.mozilla.org/mozilla-central/rev/634b48dc2f06 https://hg.mozilla.org/mozilla-central/rev/699228670afb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•