Closed Bug 883696 Opened 9 years ago Closed 9 years ago

Include full paths in all #include statements


(Core :: JavaScript Engine, defect)

Not set





(Reporter: n.nethercote, Assigned: n.nethercote)



(Whiteboard: [js:t])


(4 files)

For example, |#include "ion/Ion.h"|, not "#include "Ion.h"|
Blocks: 880088
No longer blocks: 880041
Depends on: 634839
This will make writing the header hygiene checker script in bug 880088 easier, because all #include statements will be in a consistent form.
This patch changes all the #includes in js/src/ion/ to be full paths, e.g.
ion/Ion.h instead of just Ion.h.

It's very tedious, adding "ion/" or "ion/shared/" or "ion/$PLATFORM" in lots of
places, with the following exceptions.

- jitprofiling.h doesn't exist, so I removed the relevant #include statements
  from AsmJS.cpp and AsmJSLink.cpp

- I removed the unnecessary |#include "prthread.h"| from IonBuilder.cpp.

- I removed the unnecessary |#include "Platform.h"| from RangeAnalysis.h.

- I changed |#include <mozilla/StandardInteger.h>| to the correct |#include
  "mozilla/StandardInteger.h"| in Architecture-arm.cpp.

I deliberately didn't change the ordering of any #includes (even though we have
plenty of bad orderings) to keep things simple.  That can be done later, in
another bug.
Attachment #768170 - Flags: review?(jdemooij)
This patch is like the previous one, but for js/src/assembler/ and js/src/yarr.
Non-trivial changes:

- Removed the -I flags for assembler/ and yarr/, since they're no longer

- Removed dead "methodjit/Logging.h" from MIPSAssembler.h and SparcAssembler.h.

- Removed dead "assembler/wtf/Vector.h" from ARMv7Assembler.h.

- Commented out #include "GTypedefs.h" in an unused section of Platform.h.

- I changed a bunch of local includes that erroneously used the <> form to the
  "" form.

- I changed |#include "windows.h"| to |#include <windows.h>| in
Attachment #768171 - Flags: review?(luke)
This one is trivial;  every change is the same.
Attachment #768172 - Flags: review?(luke)
Comment on attachment 768170 [details] [diff] [review]
(part 1) - Include full paths in #include statements in js/src/ion/.

Review of attachment 768170 [details] [diff] [review]:

Very nice, thanks!
Attachment #768170 - Flags: review?(jdemooij) → review+
Attachment #768171 - Flags: review?(luke) → review+
Attachment #768172 - Flags: review?(luke) → review+
Attachment #768173 - Flags: review?(luke) → review+
You need to log in before you can comment on or make changes to this bug.