883696 - Include full paths in all #include statements

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

For example, |#include "ion/Ion.h"|, not "#include "Ion.h"|

Comment 1

[Nicholas Nethercote [inactive]]

This will make writing the header hygiene checker script in bug 880088 easier, because all #include statements will be in a consistent form.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Include full paths in #include statements in js/src/ion/.

This patch changes all the #includes in js/src/ion/ to be full paths, e.g.
ion/Ion.h instead of just Ion.h.

It's very tedious, adding "ion/" or "ion/shared/" or "ion/$PLATFORM" in lots of
places, with the following exceptions.

- jitprofiling.h doesn't exist, so I removed the relevant #include statements
  from AsmJS.cpp and AsmJSLink.cpp

- I removed the unnecessary |#include "prthread.h"| from IonBuilder.cpp.

- I removed the unnecessary |#include "Platform.h"| from RangeAnalysis.h.

- I changed |#include <mozilla/StandardInteger.h>| to the correct |#include
  "mozilla/StandardInteger.h"| in Architecture-arm.cpp.

I deliberately didn't change the ordering of any #includes (even though we have
plenty of bad orderings) to keep things simple.  That can be done later, in
another bug.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Include full paths in #include statements in js/src/{assembler,yarr}/.

This patch is like the previous one, but for js/src/assembler/ and js/src/yarr.
Non-trivial changes:

- Removed the -I flags for assembler/ and yarr/, since they're no longer
  needed.

- Removed dead "methodjit/Logging.h" from MIPSAssembler.h and SparcAssembler.h.

- Removed dead "assembler/wtf/Vector.h" from ARMv7Assembler.h.

- Commented out #include "GTypedefs.h" in an unused section of Platform.h.

- I changed a bunch of local includes that erroneously used the <> form to the
  "" form.

- I changed |#include "windows.h"| to |#include <windows.h>| in
  OSAllocatorWin.cpp.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Include full paths in #include statements in js/src/jsapi-tests/

This one is trivial;  every change is the same.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Include full paths in #include statements in the rest of js/src/ and js/public/.

This one's a hodge-podge.

Comment 6

[Jan de Mooij [:jandem]]

Comment on attachment 768170 [details] [diff] [review]
(part 1) - Include full paths in #include statements in js/src/ion/.

Review of attachment 768170 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice, thanks!

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41ab7286a2e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e729e2c3822
https://hg.mozilla.org/integration/mozilla-inbound/rev/634b48dc2f06
https://hg.mozilla.org/integration/mozilla-inbound/rev/699228670afb

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/41ab7286a2e2
https://hg.mozilla.org/mozilla-central/rev/7e729e2c3822
https://hg.mozilla.org/mozilla-central/rev/634b48dc2f06
https://hg.mozilla.org/mozilla-central/rev/699228670afb