Closed Bug 883712 Opened 11 years ago Closed 4 years ago

"ASSERTION: Text leaf parent is not hypertext" with text node child of <tr>

Categories

(Core :: Disability Access APIs, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr52 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?

People

(Reporter: jruderman, Unassigned)

References

Details

(Keywords: assertion, testcase, Whiteboard: a11y:crash-tree)

Attachments

(1 file)

714 bytes, application/xhtml+xml
Details
Attached file testcase
Similar to bug 852129, but with <tr> instead of <img>.

1. Enable accessibility.
2. Load the testcase.

###!!! ASSERTION: Text leaf parent is not hypertext!: 'Error', file accessible/src/base/TextUpdater.cpp, line 49
> Similar to bug 852129, but with <tr> instead of <img>.

yeah, same basic idea this time the accessible tree is

HTMLTableRowAccessible with text leaf accessible child.
the dom tree is just a <tr> with a text leaf child.
the frame tree is table row frame with child table cell frame with child block frame all having mContent be the <tr> and then a text frame.

I'm not really sure how the accessible tree should look here.
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> > Similar to bug 852129, but with <tr> instead of <img>.
> 
> the frame tree is table row frame with child table cell frame with child
> block frame all having mContent be the <tr> and then a text frame.
> 
> I'm not really sure how the accessible tree should look here.

I'd try to rely on frame tree, i.e. expose what's supposedly on the screen

if cell is optional for table then table row should probably implement text interface
Still reproduces on trunk.
Has Regression Range: --- → no
cannot reproduce on mac, Ryan, would you mind to give a try too?
Flags: needinfo?(ryanvm)
ok, I reprodcued it locally with moz_assert. The only problem I can see that text is not accessible with weird tables like the example's one. Putting p3 for it.
Flags: needinfo?(ryanvm)
Priority: -- → P3
Whiteboard: a11y:crash-tree
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f04311c60c
replace 'Text leaf parent is not hypertext' assertion to moz_assert
The leave-open keyword is there and there is no activity for 6 months.
:surkov, maybe it's time to close this bug?
Flags: needinfo?(surkov.alexander)

The leave-open keyword is there and there is no activity for 6 months.
:Jamie, maybe it's time to close this bug?

Flags: needinfo?(jteh)

The patch here just changes the call used to raise the assertion. It doesn't actually fix the bug, hence leave-open.

That said, I'm thinking this might be fixed by bug 1052866, since that added the HyperText interface to tables and table rows. This needs testing, though.

Flags: needinfo?(jteh)
Keywords: leave-open
Flags: needinfo?(surkov.alexander)
Whiteboard: a11y:crash-tree → a11y:crash-tree[mac2020_1]

I doubt this is a mac bug. Will double check later.

Yeah, it's not mac related.

OS: macOS → All
Hardware: x86_64 → All
Whiteboard: a11y:crash-tree[mac2020_1] → a11y:crash-tree

I can't reproduce this anymore. Going to close it assuming bug 1052866, fixed it.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: