Closed Bug 883729 Opened 7 years ago Closed 7 years ago

Fix -Wnull-conversion warnings in xpcom

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24
Tracking Status
firefox23 --- wontfix
firefox24 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Ignoring a warning our copy of Google's protobuf code, these are the only -Wnull-conversion warnings I see when building Firefox for OSX:

objdir-mac/dist/include/nsInterfaceHashtable.h:138:12 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/build/FileLocation.cpp:76:12 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:250:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:257:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:268:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:871:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:882:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:1487:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:1772:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:1775:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
xpcom/components/nsComponentManager.cpp:1792:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
Attachment #763392 - Flags: review?(benjamin)
Attachment #763392 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/b6b8be9f8e0d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.