Closed
Bug 883729
Opened 11 years ago
Closed 11 years ago
Fix -Wnull-conversion warnings in xpcom
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
9.65 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Ignoring a warning our copy of Google's protobuf code, these are the only -Wnull-conversion warnings I see when building Firefox for OSX: objdir-mac/dist/include/nsInterfaceHashtable.h:138:12 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/build/FileLocation.cpp:76:12 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:250:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:257:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:268:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:871:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:882:16 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:1487:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:1772:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:1775:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t') xpcom/components/nsComponentManager.cpp:1792:20 [-Wnull-conversion] implicit conversion of NULL constant to 'decltype(nullptr)' (aka 'nullptr_t')
Attachment #763392 -
Flags: review?(benjamin)
Updated•11 years ago
|
Attachment #763392 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b8be9f8e0d
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b6b8be9f8e0d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•