883739 - test_update.js accesses https://services.addons.mozilla.org (and, indirectly, http://ocsp.verisign.com) during test run

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: disable test #20 of test_update.js

When I pushed my patch for bug 754356 to tryserver, I found that test_update.js was timing out on all platforms, causing the xpcshell tests to go orange.

Investigating locally, I noticed that this test #20 in test_update.js ends up attempting to send a request to https://services.addons.mozilla.org (and also http://ocsp.verisign.com, for the OCSP response of the cert). This seems very wrong to me, because (a) none of the other 19 tests in the file seem to be contacting services.addons.mozilla.org, and (b) no xpcshell tests should be making external network requests.

It would be great if somebody who works on addon updates could take a look at this, because it is blocking me from landing bug 754356, which I'm hoping to do for Firefox 24.

I am attaching a patch which disables test #20 of test_update.js, which causes the accesses to https://services.addons.mozilla.org to stop. This isn't meant to be a solution, but rather it just demonstrates that test #20 (continue_test_20 / check_test_20) seems to be the thing to blame.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: NSPR HTTP log showing network access to https://services.addons.mozilla.org

I am attaching an NSPR nsHttp:5 log showing the network access. Search for https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:addon12%40tests.mozilla.org?src=firefox&appOS=XPCShell&appVersion=1.

Also, here is the try run for bug 754356 that shows the xpcshell tests going orange because of the time out. Note that my patch for bug 754356 removes some timeout logic for HTTPS requests which (AFAICT) should not be necessary in Gecko any more. So, it isn't surprising that the patch for this bug would make this problem more notable. Note that my issue actually seems to be caused by a **crash**, not due to a network timeout: https://tbpl.mozilla.org/php/getParsedLog.php?id=24215512&tree=Try#error2

So, there seem to be two separate issues. This bug is supposed to be about the network access to https://services.addons.mozilla.org by the test. I will file another bug (if it isn't caused by my own patch) for the crash.

Comment 2

[:Irving Reid (No longer working on Firefox)]

Attachment: Set the correct preference so test_update.js does not access services.a.m.o

Also pulled out const definitions into head_addons.js and made them consistent.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8348995 [details] [diff] [review]
Set the correct preference so test_update.js does not access services.a.m.o

Review of attachment 8348995 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little confused. Was there a typo in the pref in test_update.js or something? I can't see any difference between the constant removed from test_update.js and that added to head_addons.js.

Comment 4

[:Irving Reid (No longer working on Firefox)]

Attachment: Set the correct preference so test_update.js does not access services.a.m.o, this time actually setting the pref

Somehow managed to make the first patch with all the incidental junk and not the one statement that fixed the problem. test_update.js around line 1180 is the part that actually matters.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8349500 [details] [diff] [review]
Set the correct preference so test_update.js does not access services.a.m.o, this time actually setting the pref

Review of attachment 8349500 [details] [diff] [review]:
-----------------------------------------------------------------

Much better!

Comment 6

[:Irving Reid (No longer working on Firefox)]

This doesn't need a build of its own.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e73e2e4ab984

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e73e2e4ab984