883751 - [System] Cannot select time while hour is one-digit

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[e-mail], [e-mail]]

Steps to reproduce:

build: 20130616030713, mozilla-central, gaia-master

==== test in Clock app ====
1. Launch Clock
2. Create new alarm
3. Click time
4. Select hour in range 1~9 with AM mode

==== test in UI tests app ====
1. Launch UI tests
2. go into Select section
3. Click time
4. Select hour in range 1~9 with AM mode

Actual results:
It cannot select time.

Expected results:
It should select time normally.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This issue only exists in m-c and should have been fixed with Bug 830353.
Not sure why this has been regressed. Will find out and fix that again.

Thanks.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10432

Pointer to Github pull-request

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 763461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10432

[Root Cause]
Only reproduced on m-c, m-c would check the fomat to be in HH:MM.
See Bug 830353 Comment 18 for details.

[Solution]
Correctly format the time as required.
This has been done in https://github.com/mozilla-b2g/gaia/pull/7752, but I am not sure why it didn't get merged at that time.
I re-send a pull request since the original one seems missing.

Dear Ian,

Please help review this one-line patch.
Thanks.

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 763461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10432

It have a test in Clock/Calendar/UI-tests app. All of them work for me. Thank you so quickly to help.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master:
https://github.com/mozilla-b2g/gaia/commit/8b152567716cf356edb826ef56152b78ec4e55a6

Ian,
Thanks for the review.