Closed Bug 883755 Opened 7 years ago Closed 7 years ago

the "SMTP" label for Outgoing server is misaligned in the account creation wizard

Categories

(Thunderbird :: Account Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 25.0

People

(Reporter: aceman, Assigned: Paenglab)

Details

(Keywords: polish)

Attachments

(3 files)

Attached image screenshot
The "SMTP" label for Outgoing server is misaligned in the account creation wizard. It is caused by these CSS rules in mail/themes/windows/mail/accountCreation.css :

#outgoing_protocol {
width: 63px;
padding-top: 5px;
}

I would remove both of them.
The problem is seen on Windows XP, but please also check all other platforms. They have differing css rules for this element.
Attached image screenshot Linux
The SMTP label is only on Windows misaligned. Removing the padding-top would solve this.

On Linux I see the first column (Incoming, Outgoing and Username) misaligned. Linux is the only using font-size: smaller; for label.textbox-label. With removing this the labels should be aligned correctly.
Confirming. I also do not understand why the labels (Incoming, Port, etc) look disabled (grey). They should be the same color/font as the "Your name" label.
Only Linux has this labels in grey. So this should also be removed.
Yes. So can you fix these?
Attached patch patchSplinter Review
Patch fixing the misalignment on Windows and the label on Linux.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #764821 - Flags: ui-review?(mconley)
Attachment #764821 - Flags: review?(mconley)
Comment on attachment 764821 [details] [diff] [review]
patch

Yes, the row labels are better now. Can you also do the column labels (Server hostname, Port, etc.) with columnHeader class?
On Windows and OS X they are also in GrayText. I leave them also on Linux untouched.
Comment on attachment 764821 [details] [diff] [review]
patch

OK then.

But they are strange, the design probably should be refreshed in another bug.
Attachment #764821 - Flags: feedback+
Comment on attachment 764821 [details] [diff] [review]
patch

Good eye!
Attachment #764821 - Flags: ui-review?(mconley)
Attachment #764821 - Flags: ui-review+
Attachment #764821 - Flags: review?(mconley)
Attachment #764821 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9ae25dce6d9f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Thanks, verified on today's trunk on Win XP.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.