883755 - the "SMTP" label for Outgoing server is misaligned in the account creation wizard

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[:aceman]

Attachment: screenshot

The "SMTP" label for Outgoing server is misaligned in the account creation wizard. It is caused by these CSS rules in mail/themes/windows/mail/accountCreation.css :

#outgoing_protocol {
width: 63px;
padding-top: 5px;
}

I would remove both of them.
The problem is seen on Windows XP, but please also check all other platforms. They have differing css rules for this element.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: screenshot Linux

The SMTP label is only on Windows misaligned. Removing the padding-top would solve this.

On Linux I see the first column (Incoming, Outgoing and Username) misaligned. Linux is the only using font-size: smaller; for label.textbox-label. With removing this the labels should be aligned correctly.

Comment 2

[:aceman]

Confirming. I also do not understand why the labels (Incoming, Port, etc) look disabled (grey). They should be the same color/font as the "Your name" label.

Comment 3

[Richard Marti (:Paenglab)]

Only Linux has this labels in grey. So this should also be removed.

Comment 4

[:aceman]

Yes. So can you fix these?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: patch

Patch fixing the misalignment on Windows and the label on Linux.

Comment 6

[:aceman]

Comment on attachment 764821 [details] [diff] [review]
patch

Yes, the row labels are better now. Can you also do the column labels (Server hostname, Port, etc.) with columnHeader class?

Comment 7

[Richard Marti (:Paenglab)]

On Windows and OS X they are also in GrayText. I leave them also on Linux untouched.

Comment 8

[:aceman]

Comment on attachment 764821 [details] [diff] [review]
patch

OK then.

But they are strange, the design probably should be refreshed in another bug.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 764821 [details] [diff] [review]
patch

Good eye!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/9ae25dce6d9f

Comment 11

[:aceman]

Thanks, verified on today's trunk on Win XP.