883759 - [Dialer] Support releasing all held calls and setting User Determined User Busy (UDUB) for a waiting call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Ben Tian (inactive)]

Bug 883505 requires BT support CHLD=0, which commands dialer to release all held calls or sets UDUB for a waiting call. This bug is to track dialer implementation.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Leo? since it blocks a blocker.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/10454

The patch is based on the bluetooth spec: "When CHLD=0, releases all held calls or sets User Determined User Busy (UDUB) for a waiting call." And it has been tested with the BT team. Etienne, could you help review it? Thanks!

BTW, The naming of the commands is getting complex when more actions are going to be implemented in the future. Owners of BT module are planning to refine the naming and filed bug 884192. Let's discuss on that bug.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 764027 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10454

Sweet and simple, thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the prompt review, Etienne!

master: https://github.com/mozilla-b2g/gaia/commit/76cca68484dc292a77fd81f0d751d47511a8d9d5

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/33b33db5eba75d7e965e0405e3cbea8a1fa467fe

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 33b33db5eba75d7e965e0405e3cbea8a1fa467fe