Closed Bug 883834 Opened 11 years ago Closed 11 years ago

Touch events position is wrong on desktop when a DOM element is scrollable

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(b2g18? fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
Tracking Status
b2g18 ? fixed
b2g-v1.1hd --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 1 obsolete file)

Touch events appear to be broken on desktop on the Marketplace, when you click on install buttons of recommanded apps, after having scrolled in the list,
you end up clicking on a random element somwhere in the page.
Attached file Pull request 10440 (obsolete) —
Assignee: nobody → poirot.alex
Attachment #763516 - Flags: review?(21)
Attached file Pull request 10440
The previous attachment pointed to the wrong pull request.  Here's a pointer to the right one.  The change fixes the problem in my tests.
Attachment #763516 - Attachment is obsolete: true
Attachment #763516 - Flags: review?(21)
Attachment #763639 - Flags: review?(21)
Attachment #763639 - Flags: feedback+
Attachment #763639 - Attachment is patch: false
Attachment #763639 - Attachment mime type: text/plain → text/html
master: 0fd75a8844db9f98e12709c9d4197f2691a0474f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Is this upliftable to v1-train as NPOTB since it's desktop-only?
(In reply to Myk Melez [:myk] [@mykmelez] from comment #4)
> Is this upliftable to v1-train as NPOTB since it's desktop-only?

vingtetun actually answered this question on bug 874521, comment 2:

> Obviously. I'm fine to give you permission to land code on Gaia and to make
> you a reviewer of the tools/extensions part as well. 
> Also landing on v1-train should be straigforward since all this directory is
> NPTOB. so a=NPTOB for all changes there (still need a review though).

This has review, and it's in tools/extensions, so it's a=NPOTB and can land on v1-train.  But I don't yet have permission to land code on Gaia, so I created a pull request for it:

  https://github.com/mozilla-b2g/gaia/pull/10675

vingtetun: can you merge this and/or give me permission to land code on Gaia so I can merge it myself?
Flags: needinfo?(21)
(In reply to Myk Melez [:myk] [@mykmelez] from comment #5)
> This has review, and it's in tools/extensions, so it's a=NPOTB and can land
> on v1-train.  But I don't yet have permission to land code on Gaia, so I
> created a pull request for it:
> 
>   https://github.com/mozilla-b2g/gaia/pull/10675
> 
> vingtetun: can you merge this and/or give me permission to land code on Gaia
> so I can merge it myself?

vingtetun gave me the aforementioned permission, and I landed it on v1-train as NPOTB:

https://github.com/mozilla-b2g/gaia/commit/da29e6fe75c37b29e032493cb7d6115e2b44ae98
Flags: needinfo?(21)
v1.1.0hd: da29e6fe75c37b29e032493cb7d6115e2b44ae98
v1.1.0hd: 7448e41aa3723736ae819d19119b770f11eefdad
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: