Closed Bug 883838 Opened 12 years ago Closed 12 years ago

edit and remix paths don't resolve the proper urls

Categories

(Webmaker Graveyard :: webmaker.org, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

They are missing some specifics to work. Shouldn't be too much though. Need to add /edit and /remix to the actual paths. Also, the actual redirect path seems to have an undefined in it.
Assignee: nobody → scott
Testing this now that the rewrite is done, shows that a few things were missed.
Attachment #763531 - Flags: review?(jon)
Blocks: 873478
Attachment #763531 - Flags: review?(schranz.m)
Blocks: 883909
Comment on attachment 763531 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/57 r- app.locals gets mixed in with res.locals when you call res.render() or app.render(). I'd turn that html template into a view that you render
Attachment #763531 - Flags: review?(schranz.m)
Attachment #763531 - Flags: review?(jon)
Attachment #763531 - Flags: review-
Attachment #763531 - Flags: review- → review?(jon)
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/17e2287e6ca0799dc0a27c92aaeb9669898215a7 Merge pull request #57 from ScottDowne/t883838 Fix bug 883838 - Fixed remix and edit routes.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #763531 - Flags: review?(jon) → review+
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: