883865 - manifestdestiny needs a writemanifest option

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

After we read manifests and filter them, it would be a much needed feature to have the ability to write the resulting annotated manifest out.  Sometimes we have to adjust paths of the tests in the manifest, this should be optional as well.  Also we should allow this to be written out to a specific location.

Currently I am doing this in a patch for mochitest manifests.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

there is a need to output the json manifest data structure to either .ini or .json.

Comment 2

[Jeff Hammel]

write() does .ini; is this adequate Joel?

https://github.com/mozilla/mozbase/blob/master/manifestdestiny/manifestparser/manifestparser.py#L563

Comment 3

[Jeff Hammel]

https://hg.mozilla.org/mozilla-central/rev/c116372d7ad4#l8.61

A missing piece of the puzzle:

"""
    8.61 +      # Bug 883865 - add this functionality into manifestDestiny
    8.62 +      with open('tests.json', 'w') as manifestFile:
    8.63 +        manifestFile.write(json.dumps({'tests': paths}))
    8.64 +      options.manifestFile = 'tests.json'
"""

It'd probably be nice to split out the de/serialization from ManifestParser class itself.

Comment 4

[(not currently active) Ted Mielczarek]

I think the JSON serialization was the main point of this bug, since that's what Joel's Mochitest patch is doing.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

what ted said, if we can somehow output .json, it would solve my original request.

Comment 6

[Geoff Brown [:gbrown]]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.