manifestdestiny needs a writemanifest option

NEW
Unassigned

Status

Testing
Mozbase
5 years ago
4 years ago

People

(Reporter: jmaher, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
After we read manifests and filter them, it would be a much needed feature to have the ability to write the resulting annotated manifest out.  Sometimes we have to adjust paths of the tests in the manifest, this should be optional as well.  Also we should allow this to be written out to a specific location.

Currently I am doing this in a patch for mochitest manifests.
(Reporter)

Comment 1

4 years ago
there is a need to output the json manifest data structure to either .ini or .json.

Comment 2

4 years ago
write() does .ini; is this adequate Joel?

https://github.com/mozilla/mozbase/blob/master/manifestdestiny/manifestparser/manifestparser.py#L563
Flags: needinfo?(jmaher)

Comment 3

4 years ago
https://hg.mozilla.org/mozilla-central/rev/c116372d7ad4#l8.61

A missing piece of the puzzle:

"""
    8.61 +      # Bug 883865 - add this functionality into manifestDestiny
    8.62 +      with open('tests.json', 'w') as manifestFile:
    8.63 +        manifestFile.write(json.dumps({'tests': paths}))
    8.64 +      options.manifestFile = 'tests.json'
"""

It'd probably be nice to split out the de/serialization from ManifestParser class itself.
I think the JSON serialization was the main point of this bug, since that's what Joel's Mochitest patch is doing.
(Reporter)

Comment 5

4 years ago
what ted said, if we can somehow output .json, it would solve my original request.
Flags: needinfo?(jmaher)
You need to log in before you can comment on or make changes to this bug.