* main nav buttons should be equally spaced. So ~50px (or whatever that is in ems) between each word, as well as the mag glass icon. * search mag glass should be aligned right with the edge of the sign up button * "sign in to save" - new language? Relevant if working on a project; otherwise perhaps confusing at first sight. Change back to "Sign in" * is blue background on 'sign up' still being cut off on the bottom? points on arrow do not look perfectly aligned. Afraid the issue might be more severe in other browsers, need to check.
One additional piece for the dropdown under Make: The "from template" and "popcorn" text need to be aligned in the middle with the icons above the text. Right now the words are too far to the right, not precisely centred.
I filed a separate bug for stuff related to sign in/sign up https://bugzilla.mozilla.org/show_bug.cgi?id=883971 Let's just space the nav items properly and also fix the dropdown - "from template" and "popcorn" text need to be centred with the icons above the text. in this ticket
Attachment #763803 - Flags: review?(dale)
Attachment #763804 - Flags: review?(dale)
Annoyed seeing dale.io, nice domain :) But guessing I shouldnt be flagged as a reviewer on here? not involved in webmaker.org
Attachment #763804 - Flags: review?(dale) → review?(dale)
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/23a2bd65bea13e3dab91933beb49e27127fb7caf [bug 883878] Fix header spacing and centering of nav items
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.