883878 - UI fixes to header: including main navigation and sign up button

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

*  main nav buttons should be equally spaced. So ~50px (or whatever that is in ems) between each word, as well as the mag glass icon.
*  search mag glass should be aligned right with the edge of the sign up button
*  "sign in to save" - new language? Relevant if working on a project; otherwise perhaps confusing at first sight. Change back to "Sign in"
*  is blue background on 'sign up' still being cut off on the bottom? points on arrow do not look perfectly aligned. Afraid the issue might be more severe in other browsers, need to check.

Comment 1

[Cassie McDaniel [:cassiemc]]

One additional piece for the dropdown under Make:

The "from template" and "popcorn" text need to be aligned in the middle with the icons above the text. Right now the words are too far to the right, not precisely centred.

Comment 2

[inactivate account for kate]

I filed a separate bug for stuff related to sign in/sign up
https://bugzilla.mozilla.org/show_bug.cgi?id=883971

Let's just space the nav items properly and also fix the dropdown - "from template" and "popcorn" text need to be centred with the icons above the text. in this ticket

Comment 3

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/169

Comment 4

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/169

Comment 5

[Dale Harvey (:daleharvey)]

Annoyed seeing dale.io, nice domain :) But guessing I shouldnt be flagged as a reviewer on here? not involved in webmaker.org

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/23a2bd65bea13e3dab91933beb49e27127fb7caf
[bug 883878] Fix header spacing and centering of nav items