883945 - b2g-info does not compile with JB Gonk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Diego Wilson [:diego]]

It fails to include the standard headers because the NDK headers changes patch between ICS and JB

gonk-misc/b2g-info/utils.h:23:18: fatal error: string: No such file or directory
compilation terminated.
make: *** [out/target/product/msm8974/obj/EXECUTABLES/b2g-info_intermediates/process.o] Error 1
In file included from gonk-misc/b2g-info/processlist.cpp:22:0:
gonk-misc/b2g-info/processlist.h:19:18: fatal error: vector: No such file or directory
compilation terminated.
make: *** [out/target/product/msm8974/obj/EXECUTABLES/b2g-info_intermediates/processlist.o] Error 1
program finished with exit code 2

Comment 1

[Justin Lebar (not reading bugmail)]

Dave, is there a right way to fix this?

Comment 2

[Diego Wilson [:diego]]

I believe the right way to fix this is to include external/stlport/libstlport.mk in Android.mk instead of adding these include paths:

https://github.com/mozilla-b2g/gonk-misc/blob/master/b2g-info/Android.mk#L24

Comment 3

[Diego Wilson [:diego]]

Also, my compiler doesn't like the name of one of this variable for some reason:

https://github.com/mozilla-b2g/gonk-misc/blob/master/b2g-info/utils.cpp#L31

I suggest changing it to "pageSize" instead of "PAGE_SIZE". It may be clashing with a macro or something.

Comment 4

[Justin Lebar (not reading bugmail)]

> It may be clashing with a macro or something.

Yeah, that's probably it.  I thought I'd managed not to include that header, but I guess not everywhere.

Comment 5

[Justin Lebar (not reading bugmail)]

I'll fix this after lunch today, but it sounds like you already know what you need to do to fix it, so I'd certainly appreciate if you have a chance to send me a PR.

Comment 6

[Justin Lebar (not reading bugmail)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gonk-misc/pull/99

Pointer to Github pull-request

Comment 7

[Justin Lebar (not reading bugmail)]

Comment on attachment 763785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gonk-misc/pull/99

Can you let me know if this fixes the problem on your end, Diego?

Comment 8

[Diego Wilson [:diego]]

(In reply to Justin Lebar [:jlebar] from comment #7)
> Comment on attachment 763785 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gonk-misc/pull/99
> 
> Can you let me know if this fixes the problem on your end, Diego?

Patch works for me!

Comment 9

[Michael Wu [:mwu]]

Comment on attachment 763785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gonk-misc/pull/99

Going to merge this since it fixes bustage.

Comment 10

[Michael Wu [:mwu]]

Merged.