Closed Bug 883945 Opened 9 years ago Closed 9 years ago

b2g-info does not compile with JB Gonk

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: diego, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

It fails to include the standard headers because the NDK headers changes patch between ICS and JB

gonk-misc/b2g-info/utils.h:23:18: fatal error: string: No such file or directory
compilation terminated.
make: *** [out/target/product/msm8974/obj/EXECUTABLES/b2g-info_intermediates/process.o] Error 1
In file included from gonk-misc/b2g-info/processlist.cpp:22:0:
gonk-misc/b2g-info/processlist.h:19:18: fatal error: vector: No such file or directory
compilation terminated.
make: *** [out/target/product/msm8974/obj/EXECUTABLES/b2g-info_intermediates/processlist.o] Error 1
program finished with exit code 2
Blocks: gonk-jb
Flags: needinfo?(justin.lebar+bug)
Dave, is there a right way to fix this?
Flags: needinfo?(justin.lebar+bug)
Flags: needinfo?(dhylands)
I believe the right way to fix this is to include external/stlport/libstlport.mk in Android.mk instead of adding these include paths:

https://github.com/mozilla-b2g/gonk-misc/blob/master/b2g-info/Android.mk#L24
Also, my compiler doesn't like the name of one of this variable for some reason:

https://github.com/mozilla-b2g/gonk-misc/blob/master/b2g-info/utils.cpp#L31

I suggest changing it to "pageSize" instead of "PAGE_SIZE". It may be clashing with a macro or something.
> It may be clashing with a macro or something.

Yeah, that's probably it.  I thought I'd managed not to include that header, but I guess not everywhere.
I'll fix this after lunch today, but it sounds like you already know what you need to do to fix it, so I'd certainly appreciate if you have a chance to send me a PR.
Blocks: 864597
Flags: needinfo?(dhylands)
Assignee: nobody → justin.lebar+bug
Comment on attachment 763785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gonk-misc/pull/99

Can you let me know if this fixes the problem on your end, Diego?
Attachment #763785 - Flags: review?(dhylands)
Attachment #763785 - Flags: feedback?(dwilson)
(In reply to Justin Lebar [:jlebar] from comment #7)
> Comment on attachment 763785 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gonk-misc/pull/99
> 
> Can you let me know if this fixes the problem on your end, Diego?

Patch works for me!
Attachment #763785 - Flags: feedback?(dwilson) → feedback+
Comment on attachment 763785 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gonk-misc/pull/99

Going to merge this since it fixes bustage.
Attachment #763785 - Flags: review?(dhylands) → review+
Merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.