883958 - Apps with unsupported pricetiers should be listed as "Not available"

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Not all apps and their price tiers will be supported across various regions. On desktop, users can still end up on the app's details page. We need to show a meaningful button status in this case.

steps to reproduce:
1. Change your country to Poland
2. Load https://marketplace-dev.allizom.org/app/pricepoint90-1499/

expected behavior:
The button status says "Not available" or there is a user message saying "This app is unavailable for your region"

observed behavior:
The button status incorrectly says "Free"

Comment 1

[Andy McKay]

Similar to bug 878215.

Comment 2

[Wil Clouser [:clouserw]]

doesn't block, p2

Comment 3

[Maureen Hanratty]

The button should be disabled and have whatever the price would be. Showing a message to the user sounds like a good idea. We used to show "This is a mobile only app" for mobile only apps like Twitter on desktop. Did that go away in the redesign? (Or did UX ask to get rid of it--maybe its my bad!)

Let's try to document what apps to show on what devices and what the buttons and messages should be in this Google Doc so everyone on the has an understanding of what is being shown where: 

https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Ah25m1c88sSodG9xdHZndFFHeG5IOHpXMU5xbExDMkE#gid=0

Comment 4

[Christopher Van Wiemeersch [:cvan]]

WIP: https://github.com/cvan/fireplace/commit/480efbf

I thought about how bug 889056 will affect Fireplace. Then I remembered we're already sending down the regions for each app (http://f.cl.ly/items/2W3X1d0J2N1s063r0842/Screen%20Shot%202013-07-02%20at%207.59.17%20AM.png). But it's looking like probably just want the API to return in the API response the availability per `price_tier` (and based on the waffle flags and `has_payments` booleans). Thoughts, people?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/aba2482
https://github.com/mozilla/fireplace/commit/1338f3d

Waiting for a commit by Andy to fix the API, and we're good here =)

Comment 6

[Andy McKay]

I don't think the API needs a fix actually. 

app.get_tier() will return the tier, irrelevant of the region. If there's no tier, payment is not required. If there is a tier payment is required. The get_price(..) higher up does the region specific work.

In the case of Seville, for a tier that doesn't exist, get_price(region=...) will be empty, but get_tier() isn't. This means that payment_required is True.

If any of that is wrong please let me know.

https://github.com/mozilla/zamboni/blob/master/mkt/webapps/utils.py#L118

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Oh it will? In that case, we're good. Thanks, Andy!

Comment 8

[Victor Carciu]

I think that the correct messages are now displayed : http://screencast.com/t/iGZBkR3MLlw .
Krupa, can we mark this bug as verified with the actual messages?

Comment 9

[krupa raj[:krupa]]

(In reply to Victor Carciu from comment #8)
> I think that the correct messages are now displayed :
> http://screencast.com/t/iGZBkR3MLlw .
> Krupa, can we mark this bug as verified with the actual messages?

The idea is that the button status says "Unavailable". See http://screencast.com/t/CcOIz6efIbR3

 What region are you in?

Comment 10

[Maureen Hanratty]

I think it is better for the button to be disabled but still maintain the "Free" or "$.99" rather than changing the button to say "Unavailable". Thoughts?

Comment 11

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maureen Hanratty from comment #10)
> I think it is better for the button to be disabled but still maintain the
> "Free" or "$.99" rather than changing the button to say "Unavailable".
> Thoughts?

That's what I originally thought, but $0.99 is not actually the price because the tier itself does not exist in the US.

Andy, yeah?