88397 - #ifdef xptcall code for gcc-2.7.2.x on x86

Status: VERIFIED FIXED

(Core :: XPConnect, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Every time I set up gcc-2.7.2.3 on x86 (well, twice so far, but I think I've had
to do it on 2 separate trees on the first machine), I have to #ifdef the xptcall
code so that I can get my gcc 2.7.2.3 build running.  If I check this #ifdef-ing
in then other people could run on gcc-2.7.2.3 on x86 as well (to test changes
for gcc-2.7.2.3 on Sun).  I'll attach the patch I wrote this time around.  (I'm
not sure what gcc 2.8.x does, so I assumed gcc 2.8.x currently works even though
I suspect it doesn't.)  I think gcc 2.7.2.x may have the -fvtable-thunks option
to change which way the vtable works but I don't know of a way to detect it at
compile time.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Chris Waterson]

r=waterson

Comment 3

[Mike Shaver (:shaver emeritus)]

sr=shaver (finally).

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2001-08-01 19:02 PDT.

Comment 5

[Phil Schwartau]

Verified.