let the httpd server choose its port in reftests

RESOLVED FIXED in mozilla24

Status

Testing
Reftest
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 763719 [details] [diff] [review]
let the httpd server choose its port in reftests

The http server, by virtue of using nsIServerSocket, can choose its own port.
So let's delegate the port choosing to the server rather than faking it
ourselves.
Attachment #763719 - Flags: review?(ted)
(Assignee)

Updated

5 years ago
Blocks: 813742
Assignee: nobody → nfroyd
Comment on attachment 763719 [details] [diff] [review]
let the httpd server choose its port in reftests

Review of attachment 763719 [details] [diff] [review]:
-----------------------------------------------------------------

This is so much nicer. :)

::: layout/tools/reftest/reftest.js
@@ +1089,1 @@
>                                           path + dirPath,

Can you fix this weird indentation while you're here?
Attachment #763719 - Flags: review?(ted) → review+
Component: General → Reftest
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> >                                           path + dirPath,
> 
> Can you fix this weird indentation while you're here?

What would make it not "weird"?
(Assignee)

Comment 4

5 years ago
(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #3)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> > >                                           path + dirPath,
> > 
> > Can you fix this weird indentation while you're here?
> 
> What would make it not "weird"?

It ought to line up with the first parameter of the function call, shouldn't it?  Unless the extra indentation is meant to signal a continuation line of some sort.
It's meant to signal that it's a continuation of a parameter rather than a new one.

Comment 6

5 years ago
If a parameter is too long, I prefer to assign it to a variable in order to avoid the line continuation.

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/78ecf4488be0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.