"Prebuilt items" and "Values" should coexist when adding items to widgets

RESOLVED FIXED in Firefox 24

Status

P3
normal
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 24

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

5 years ago
Created attachment 765310 [details] [diff] [review]
v1

Anton, would you like me to change anything else in the Profiler?
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #765310 - Flags: review?(rcampbell)
Attachment #765310 - Flags: review?(anton)
(Assignee)

Updated

5 years ago
Priority: -- → P3
Comment on attachment 765310 [details] [diff] [review]
v1

Review of attachment 765310 [details] [diff] [review]:
-----------------------------------------------------------------

I think that's chill. The code can now be refactored to have UIDs as values, instead of putting them into attachments but, I think it's better to do that in a followup. (File a bug, please?)
Attachment #765310 - Flags: review?(anton) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Anton Kovalyov (:anton) from comment #2)
> Comment on attachment 765310 [details] [diff] [review]
> v1
> 
> Review of attachment 765310 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think that's chill. The code can now be refactored to have UIDs as values,
> instead of putting them into attachments but, I think it's better to do that
> in a followup. (File a bug, please?)

Yeah, I was thinking about doing that too, but I wanted to check with you first. Ok!
Comment on attachment 765310 [details] [diff] [review]
v1

Review of attachment 765310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ -259,5 @@
>   */
>  function RequestsMenuView() {
>    dumpn("RequestsMenuView was instantiated");
>  
> -  this._cache = new Map(); // Can't use a WeakMap because keys are strings.

didn't we just add this? :)
Attachment #765310 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> Comment on attachment 765310 [details] [diff] [review]
> v1
> 
> Review of attachment 765310 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/netmonitor/netmonitor-view.js
> @@ -259,5 @@
> >   */
> >  function RequestsMenuView() {
> >    dumpn("RequestsMenuView was instantiated");
> >  
> > -  this._cache = new Map(); // Can't use a WeakMap because keys are strings.
> 
> didn't we just add this? :)

It was there since the Network Monitor inception, so .. no, it's pretty old. In the light of recent changes, it's also unnecessary and obsolete.
https://hg.mozilla.org/mozilla-central/rev/1d52e5f47f5a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.