Closed
Bug 884006
Opened 9 years ago
Closed 9 years ago
"Prebuilt items" and "Values" should coexist when adding items to widgets
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
12.50 KB,
patch
|
rcampbell
:
review+
anton
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•9 years ago
|
||
Anton, would you like me to change anything else in the Profiler?
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #765310 -
Flags: review?(rcampbell)
Attachment #765310 -
Flags: review?(anton)
Assignee | ||
Updated•9 years ago
|
Priority: -- → P3
Comment 2•9 years ago
|
||
Comment on attachment 765310 [details] [diff] [review] v1 Review of attachment 765310 [details] [diff] [review]: ----------------------------------------------------------------- I think that's chill. The code can now be refactored to have UIDs as values, instead of putting them into attachments but, I think it's better to do that in a followup. (File a bug, please?)
Attachment #765310 -
Flags: review?(anton) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Anton Kovalyov (:anton) from comment #2) > Comment on attachment 765310 [details] [diff] [review] > v1 > > Review of attachment 765310 [details] [diff] [review]: > ----------------------------------------------------------------- > > I think that's chill. The code can now be refactored to have UIDs as values, > instead of putting them into attachments but, I think it's better to do that > in a followup. (File a bug, please?) Yeah, I was thinking about doing that too, but I wanted to check with you first. Ok!
Comment 4•9 years ago
|
||
Comment on attachment 765310 [details] [diff] [review] v1 Review of attachment 765310 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/netmonitor/netmonitor-view.js @@ -259,5 @@ > */ > function RequestsMenuView() { > dumpn("RequestsMenuView was instantiated"); > > - this._cache = new Map(); // Can't use a WeakMap because keys are strings. didn't we just add this? :)
Attachment #765310 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #4) > Comment on attachment 765310 [details] [diff] [review] > v1 > > Review of attachment 765310 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/devtools/netmonitor/netmonitor-view.js > @@ -259,5 @@ > > */ > > function RequestsMenuView() { > > dumpn("RequestsMenuView was instantiated"); > > > > - this._cache = new Map(); // Can't use a WeakMap because keys are strings. > > didn't we just add this? :) It was there since the Network Monitor inception, so .. no, it's pretty old. In the light of recent changes, it's also unnecessary and obsolete.
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1d52e5f47f5a
Whiteboard: [fixed-in-fx-team]
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d52e5f47f5a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•