884013 - "My application" string overflows while the page loads

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Set the language on your Firefox OS phone to Spanish
2. Log in to marketplace-dev app
3. Click on "Mis aplicaciones"
4. Notice the tab label while the page loads



observed behavior:
"My application" string overflows while the page loads. See screenshot

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Isn't this the same bug as bug 877082 which was verified?

Comment 2

[krupa raj[:krupa]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #1)
> Isn't this the same bug as bug 877082 which was verified?

I don't think so. Bug 877082 was about the string being cut off in otehr locales. This bug is about overflow problem while the page is loading.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/505e3dc

Gotcha - thanks, Krupa =)

Comment 4

[krupa raj[:krupa]]

verified fixed in es

Comment 5

[krupa raj[:krupa]]

I was too hasty in marking this verified. This issue still happens on the Feedback form.

Comment 6

[krupa raj[:krupa]]

Attachment: screenshot on feedback form

Comment 7

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/d0faa44

My bad! It was working most of the time - sorry I regressed the old case whilst fixing the new case =P

Comment 8

[Victor Carciu]

Verified as fixed : http://screencast.com/t/ha7qEXrgPw 

I am not sure if this can be solved , but the "Mis applicaciones" font size is visible different than the text of other tabs. Do we have any solution for this ?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Victor Carciu from comment #8)
> Verified as fixed : http://screencast.com/t/ha7qEXrgPw 
> 
> I am not sure if this can be solved , but the "Mis applicaciones" font size
> is visible different than the text of other tabs. Do we have any solution
> for this ?

That's the solution. If the text would otherwise wrap to the next line, we shrink the font-size until the text doesn't wrap.