Closed Bug 884014 Opened 6 years ago Closed 6 years ago

Can't build QuartzSupport with 10.9 SDK

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox27 --- fixed
firefox-esr24 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: Nomis101, Assigned: smichaud)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

Attached file Build error
Today I've tried to build with 10.9 SDK on OS X Mavericks. It stopped with the error I've attached.

OS X 10.9 13A476u, Xcode 5, current m-c trunk.
You probably need to build against the 10.7 or 10.8 SDK?
Sure, it builds fine with the 10.7 and 10.8 SDK. Seems I have forgotten a proper explanation for this bug. OS X Mavericks will be the new Mac OS and comes with the 10.9 SDK. It introduces new features and APIs. If mozilla wants to support any of this new features we must be able to build against the 10.9 SDK. Therefore I've filled this bug, for incompatibility documentation. I think currently its to early to worry about this, this is the first developer preview of Mavericks and the 10.9 SDK. Maybe Apple will change something here for the final release.
With Apple's latest stuff, I don't see these errors building current trunk using either the 10.8 or 10.9 SDK.

My setup:

OS X 10.9 DP 7 (13A569)
XCode 5 DP6 (5A11386k)
Commandline Tools for XCode 5 DP6 (including clang-500.1.74)
Strange, with the same setup and the latest trunk I still get this errors (10.9 SDK). What does your mozconfig look like?
Here's the mozconfig I've been testing with:

export CC="clang"
export CXX="clang++"
export CFLAGS="-g -gfull"
export CXXFLAGS="-g -gfull"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox-64bit
mk_add_options MOZ_MAKE_FLAGS=-j4
mk_add_options AUTOCONF=autoconf213
ac_add_options --disable-optimize
ac_add_options --enable-tests
ac_add_options --enable-cpp-rtti
ac_add_options --enable-logrefcnt
ac_add_options --disable-strip
ac_add_options --disable-install-strip
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.9.sdk

(And note that I've created softlinks in /Developer to XCode's SDKs and Tools directories.)

But I'm no longer so sure of what I say in comment #3, because I'm now getting a different error when I build.  I'll have more to say once I track down that error.
Oops, forgot to mention that I'm also building --without-intl-api (which works around bug 901348).
OK, with your mozconfig it stops for me at js/src/config/pathsub.c
With the following mozconfig file I get around the error you mentioned in comment #7 and see the errors you reported here.  Sorry for the confusion.

export CC="clang"
export CXX="clang++"
export CFLAGS="-g -gfull"
export CXXFLAGS="-g -gfull"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox-64bit
mk_add_options MOZ_MAKE_FLAGS=-j4
mk_add_options AUTOCONF=autoconf213
#ac_add_options --disable-optimize
ac_add_options --enable-tests
ac_add_options --enable-cpp-rtti
ac_add_options --enable-logrefcnt
ac_add_options --disable-strip
ac_add_options --disable-install-strip
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.9.sdk
ac_add_options --without-intl-api

I'll open another bug about the error from comment #6.  I don't believe it's been reported yet.
No longer blocks: mavericks-compat
> I'll open another bug about the error from comment #6.

I've opened bug 917526.
Attached patch FixSplinter Review
This fixes the problem in my tests.

Tryserver test results confirm that it doesn't cause trouble using other SDKs.
Assignee: nobody → smichaud
Status: NEW → ASSIGNED
Attachment #807787 - Flags: review?(bgirard)
Comment on attachment 807787 [details] [diff] [review]
Fix

Review of attachment 807787 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you. Should we get the ball rolling for getting 10.9 testing?
Attachment #807787 - Flags: review?(bgirard) → review+
> Thank you.

You're most welcome.

> Should we get the ball rolling for getting 10.9 testing?

Probably a good idea.  But at least for the time being we can only use the 10.8 SDK:  No earlier SDKs are available for building on 10.9, and there are still some unresolved 10.9-SDK build bugs -- including one that (seemingly) requires a fairly major change to fix (bug 917526), and so may not be resolved soon.
https://hg.mozilla.org/mozilla-central/rev/0accdf78d53c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Ryan, can you uplift this to esr24?
Flags: needinfo?(ryanvm)
Whiteboard: [qa-]
Blocks: 1159706
You need to log in before you can comment on or make changes to this bug.