884017 - Developer Pages are not available in french anymore on production server

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[:gerard-majax]

This https://marketplace.firefox.com/developers/?lang=fr used to work a couple of days/weeks ago. Now it stays in english. Development version works https://marketplace-dev.allizom.org/developers/?lang=fr

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Interestingly, https://marketplace.firefox.com/developers/?lang=es works

Comment 2

[Mathieu Pillard [:mat]]

I spent some time on it but I am not sure if it's supposed to work and what changed from before.

From what I can tell, the code checks settings.LANGUAGE_URL_MAP to validate the language. That setting uses AMO_LANGUAGES, which is set to AMO_LANGUAGES = ('de', 'en-US', 'es', 'pl', 'pt-BR') in marketplace settings. That setting was changed one month ago to add 'de', but that's it. The validation code and the middleware code that deals with language haven't changed recently, except to stop storing cookies when dealing with API stuff.

-dev works because it has a custom AMO_LANGUAGES.

Comment 3

[Wil Clouser [:clouserw]]

let's add fr to AMO_LANGUAGES in prod

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/1f3a179bf59e0ad27dae162203f6f486fe25a008

Steps to reproduce:
- Load /developers/?lang=fr
- Check if the page is translated in french

Comment 5

[Victor Carciu]

Still reproducible in prod : http://screencast.com/t/x4FipIAWg9IS

Comment 6

[Mathieu Pillard [:mat]]

Prod hasn't been updated yet. It works on stage though : https://marketplace.allizom.org/developers/?lang=fr

Comment 7

[Victor Carciu]

Okay , then I will mark it as verified.