Closed Bug 884020 Opened 6 years ago Closed 6 years ago

Don't use the register keyword in SVG code

Categories

(Core :: SVG, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (v1) (obsolete) — Splinter Review
This breaks builds with recent clang and warnings-as-errors:

33:57.83 /media/storage/moz/src/content/svg/content/src/SVGFETurbulenceElement.cpp:267:3: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
33:57.83   register long i, j;
33:57.83   ^~~~~~~~~
33:57.83 /media/storage/moz/src/content/svg/content/src/SVGFETurbulenceElement.cpp:267:3: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
33:57.83   register long i, j;
33:57.83   ^~~~~~~~~
Attachment #763775 - Flags: review?(dholbert)
Assignee: nobody → ehsan
Comment on attachment 763775 [details] [diff] [review]
Patch (v1)

Looks like this has had the "register" keyword since we added support for feTurbulence in bug 326143.

I'm happy to trust that compilers are smart enough to optimize this sort of thing on their own, particularly if the keyword is deprecated.
Attachment #763775 - Flags: review?(dholbert) → review+
Depends on: 326143
(In reply to comment #1)
> Comment on attachment 763775 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=763775
> Patch (v1)
> 
> Looks like this has had the "register" keyword since we added support for
> feTurbulence in bug 326143.
> 
> I'm happy to trust that compilers are smart enough to optimize this sort of
> thing on their own, particularly if the keyword is deprecated.

The compilers are even smarter than that!  They just give you a blank look, roll their eyes, shake their head, and ignore you!
Attached patch For check-inSplinter Review
Attachment #763775 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a8ef7f74a46
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.