884020 - Don't use the register keyword in SVG code

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[:ehsan akhgari]

Attachment: Patch (v1)

This breaks builds with recent clang and warnings-as-errors:

33:57.83 /media/storage/moz/src/content/svg/content/src/SVGFETurbulenceElement.cpp:267:3: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
33:57.83   register long i, j;
33:57.83   ^~~~~~~~~
33:57.83 /media/storage/moz/src/content/svg/content/src/SVGFETurbulenceElement.cpp:267:3: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
33:57.83   register long i, j;
33:57.83   ^~~~~~~~~

Comment 1

[Daniel Holbert [:dholbert]]

Comment on attachment 763775 [details] [diff] [review]
Patch (v1)

Looks like this has had the "register" keyword since we added support for feTurbulence in bug 326143.

I'm happy to trust that compilers are smart enough to optimize this sort of thing on their own, particularly if the keyword is deprecated.

Comment 2

[:ehsan akhgari]

(In reply to comment #1)
> Comment on attachment 763775 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=763775
> Patch (v1)
> 
> Looks like this has had the "register" keyword since we added support for
> feTurbulence in bug 326143.
> 
> I'm happy to trust that compilers are smart enough to optimize this sort of
> thing on their own, particularly if the keyword is deprecated.

The compilers are even smarter than that!  They just give you a blank look, roll their eyes, shake their head, and ignore you!

Comment 3

[:ehsan akhgari]

Attachment: For check-in

Comment 4

[:ehsan akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a8ef7f74a46

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8a8ef7f74a46