Don't finalize a context if it has active rooters

RESOLVED FIXED in mozilla24

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.12 KB, patch
sfink
: review+
Bobby Holley (parental leave - send mail for anything urgent)
: feedback+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Created attachment 763810 [details] [diff] [review]
v0

I was able to start a browser, go to wikipedia, then shutdown without hitting this assertion. Throwing it at try now:

https://tbpl.mozilla.org/?tree=Try&rev=7dd583be2ded
Attachment #763810 - Flags: review?(sphink)
Attachment #763810 - Flags: feedback?(bobbyholley+bmo)
(Assignee)

Comment 1

4 years ago
Comment on attachment 763810 [details] [diff] [review]
v0

This seems to be the wrong patch. Will get back to you once I make sure I actually tested the patch with the assertions in it.
Attachment #763810 - Flags: review?(sphink)
Attachment #763810 - Flags: feedback?(bobbyholley+bmo)
(Assignee)

Comment 2

4 years ago
Created attachment 764252 [details] [diff] [review]
v1: this time with actual content

Rebuilt after updating the patch and the browser still seems to run and exit cleanly.
Attachment #763810 - Attachment is obsolete: true
Attachment #764252 - Flags: review?(sphink)
Attachment #764252 - Flags: feedback?(bobbyholley+bmo)
Attachment #764252 - Flags: review?(sphink) → review+
Comment on attachment 764252 [details] [diff] [review]
v1: this time with actual content

Review of attachment 764252 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #764252 - Flags: feedback?(bobbyholley+bmo) → feedback+
(Assignee)

Comment 4

4 years ago
Excellent! Lets Try and see how much my "test" missed:

https://tbpl.mozilla.org/?tree=Try&rev=12c7309edbe6
(Assignee)

Comment 5

4 years ago
Well, the orange looks like orange-factor to me, so lets do this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f6621f6873
https://hg.mozilla.org/mozilla-central/rev/43f6621f6873
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.