884065 - Don't finalize a context if it has active rooters

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

I was able to start a browser, go to wikipedia, then shutdown without hitting this assertion. Throwing it at try now:

https://tbpl.mozilla.org/?tree=Try&rev=7dd583be2ded

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 763810 [details] [diff] [review]
v0

This seems to be the wrong patch. Will get back to you once I make sure I actually tested the patch with the assertions in it.

Comment 2

[Terrence Cole [:terrence]]

Attachment: v1: this time with actual content

Rebuilt after updating the patch and the browser still seems to run and exit cleanly.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 764252 [details] [diff] [review]
v1: this time with actual content

Review of attachment 764252 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 4

[Terrence Cole [:terrence]]

Excellent! Lets Try and see how much my "test" missed:

https://tbpl.mozilla.org/?tree=Try&rev=12c7309edbe6

Comment 5

[Terrence Cole [:terrence]]

Well, the orange looks like orange-factor to me, so lets do this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f6621f6873

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43f6621f6873