884078 - Footer logos animation

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

* can we get logos to fade in one by one. Want to make each partner seem unique, not tied to the group of three in which they appear.

* can we slow the logo fade animation

Comment 1

[Cassie McDaniel [:cassiemc]]

FYI this partners section isn't showing in the footer on mobile. Bug 890914

Comment 2

[Ali Al Dallal [:alicoding]]

I'm passing this to someone else first. If anyone can finish this quick then it will be great otherwise I will do this after I finish the localization on Webmaker (Only webmaker.org)

Comment 3

[Gavin Suntop [:gvn]]

I'll work on it. :)

Comment 4

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker.org/pull/281

Comment 5

[inactivate account for kate]

Comment on attachment 779331 [details] [review]
https://github.com/mozilla/webmaker.org/pull/281

Awesome, works well.

A few style nits, some lint errors:
[L32:C24] W070: Extra comma. (it breaks older versions of IE)
      fadeInSpeed: 1000,
[L59:C4] W033: Missing semicolon.
  } 
[L77:C9] W033: Missing semicolon.
      }) 
[L124:C78] W033: Missing semicolon.
          self.showGroup(self.visibleItems[self.visibleItems.length - 1] + 1) 
[L145:C4] W033: Missing semicolon.
  } 

Fix those up and let's land this

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/750de425eb903c96aeeb737a94f09f531d48ddad
Fix bug 884078 - Rewriting Partners marquee in footer