88411 - ns[C]StringKey doesn't cooperate with strings very well

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

From discussion on IRC and scc's bustage this morning, we've found a few
problems with ns[C]StringKey.

 * The nsAReadableString ctor of nsStringKey doesn't work for non-flat strings
since the promise goes away, freeing the string it points to

 * There is no way to construct an nsCStringKey from an nsACString.

Proposed short-term solution:
 * have 3 constructors for ns[C]StringKey:
     * const PRUnichar*/const char* (existing)
     * nsAFlatString -- works like the current nsAReadableString ctor on
       nsStringKey except without bothering with PromiseFlatString
     * nsAString - a new constructor that just copies the string and owns it.

In the long term we may want to have ns[C]StringKey participate in sharing.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

scc just attatched a first attempt at a patch to bug 74726 as attachment 40639 [details] [diff] [review]

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: changes I was proposing (not yet tested)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch above, patch to bug 88420, and backout of unneeded bustage fixes for this bug

Comment 4

[jag (Peter Annema)]

r=jag

Comment 5

[Chris Waterson]

sr=waterson

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Built patch on gcc 2.7.2.3, gcc 3.0, VC6, and MW (Mac).  Ran precheckin tests
fully on Windows and Mac, partially (different parts) on both Linux builds.

Comment 7

[Scott Collins]

giving up ancient string bugs to the new string owner.  jag, you'll want to sort
through these and see which ones still apply and go with or against the
direction in which you intend strings evolve

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also bug 119745.

Comment 9

[Markus Hübner]

What is there that needs to be fixing?