Closed Bug 884133 Opened 10 years ago Closed 10 years ago

Kill unnecessary references to sAppContext in GeckoApp

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(1 file)

Patch
10.19 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
GeckoApp uses sAppContext in many places where they are not needed.
Attached patch Patch — — Splinter Review 

        Attachment #763917 -
        Flags: review?(blassey.bugs)

    
    

    
  
Comment on attachment 763917 [details] [diff] [review]
Patch

Review of attachment 763917 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +926,3 @@
>          final String fileName = aSrc.substring(aSrc.lastIndexOf("/") + 1);
> +        final PendingIntent emptyIntent = PendingIntent.getActivity(this, 0, new Intent(), 0);
> +        final AlertNotification notification = new AlertNotification(this, fileName.hashCode(), 

trailing ws here

        Attachment #763917 -
        Flags: review?(blassey.bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/35a76cc3c2c8
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.