Closed
Bug 884133
Opened 12 years ago
Closed 12 years ago
Kill unnecessary references to sAppContext in GeckoApp
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: sriram, Assigned: sriram)
Details
Attachments
(1 file)
|
10.19 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
GeckoApp uses sAppContext in many places where they are not needed.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #763917 -
Flags: review?(blassey.bugs)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 763917 [details] [diff] [review]
Patch
Review of attachment 763917 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/GeckoApp.java
@@ +926,3 @@
> final String fileName = aSrc.substring(aSrc.lastIndexOf("/") + 1);
> + final PendingIntent emptyIntent = PendingIntent.getActivity(this, 0, new Intent(), 0);
> + final AlertNotification notification = new AlertNotification(this, fileName.hashCode(),
trailing ws here
Attachment #763917 -
Flags: review?(blassey.bugs) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
||
Comment 4•12 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•