884133 - Kill unnecessary references to sAppContext in GeckoApp

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

GeckoApp uses sAppContext in many places where they are not needed.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 763917 [details] [diff] [review]
Patch

Review of attachment 763917 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +926,3 @@
>          final String fileName = aSrc.substring(aSrc.lastIndexOf("/") + 1);
> +        final PendingIntent emptyIntent = PendingIntent.getActivity(this, 0, new Intent(), 0);
> +        final AlertNotification notification = new AlertNotification(this, fileName.hashCode(), 

trailing ws here

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35a76cc3c2c8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/35a76cc3c2c8