Messages to vold need sequence number in gonk-JB

RESOLVED FIXED in mozilla25

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
mozilla25
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Messages to vold now require a sequence number at the beginning.
false on this line [1] will get vold working again with no gecko changes.  

[1] https://www.codeaurora.org/cgit/quic/la/platform/system/vold/tree/CommandListener.cpp?h=jb_mr1#n46
(Assignee)

Comment 2

5 years ago
So does unconditionally passing 0 as a sequence number. Not sure this stuff actually does much for what we use it for..
Na, seems to be just for multiple clients and we don't have that use case atm.   netd fix is the same (0 or false)
(Assignee)

Comment 4

5 years ago
Created attachment 764923 [details] [diff] [review]
Prefix a sequence number on vold commands on gonk-JB

I don't have a JB device with internal or external SD cards, so it would be nice to get confirmation if this completely fixes volume handling or not.
Assignee: nobody → mwu
Attachment #764923 - Flags: review?(dhylands)
Attachment #764923 - Flags: feedback?(mvines)
Comment on attachment 764923 [details] [diff] [review]
Prefix a sequence number on vold commands on gonk-JB

The sequence number ("0") is also returned back from vold, so needs to be skipped over at http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/VolumeManager.cpp#154
Attachment #764923 - Flags: feedback?(mvines)
(Assignee)

Comment 6

5 years ago
Created attachment 767905 [details] [diff] [review]
Handle sequence numbers on vold commands on gonk-JB

This patch also strips sequence numbers from incoming messages. We continue to assume the sequence number is zero.
Attachment #764923 - Attachment is obsolete: true
Attachment #764923 - Flags: review?(dhylands)
Attachment #767905 - Flags: review?(dhylands)
Attachment #767905 - Flags: feedback?(mvines)
Attachment #767905 - Flags: feedback?(mvines) → feedback+
Comment on attachment 767905 [details] [diff] [review]
Handle sequence numbers on vold commands on gonk-JB

Review of attachment 767905 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #767905 - Flags: review?(dhylands) → review+
https://hg.mozilla.org/mozilla-central/rev/764b9c296e69
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.