Closed
Bug 884150
Opened 12 years ago
Closed 12 years ago
Fix Android tests on mozilla-release
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: kmoir)
Details
Attachments
(2 files)
1.16 KB,
patch
|
kmoir
:
review+
|
Details | Diff | Splinter Review |
3.67 KB,
patch
|
mozilla
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
* we should be running tests on Pandas there, but we aren't
* we should be running chunked robocop, but we aren't
* we may or may not be running reftests wrong, I couldn't puzzle that part out
* we shouldn't be running mochitest-gl on Tegras
Most of that is because of TEGRA_RELEASE_PLAIN_UNITTEST_DICT, which should have gone away, but not necessarily all of it.
Since the code was fine when it left mozilla-beta, we're almost certainly fine until the moment we need to land something on mozilla-release, when we're screwed, since that branch can only run mochitest-gl on Pandas, not on Tegras.
Assignee | ||
Comment 1•12 years ago
|
||
I can look at this when I get back week unless someone else wants to. I plan to land the changes for bug 829211 first so our mobile configs are less ugly and easier to work with first.
Reporter | ||
Comment 2•12 years ago
|
||
My nervousness about us needing a chemspill, forgetting that we're missing half the tests we should be running on Android, forgetting that we don't have the other half running at all, and just going ahead with it, finally spilled over.
mozilla-release is closed.
Severity: critical → blocker
Comment 3•12 years ago
|
||
Totally forgot about this file. This should take care of:
* we should be running tests on Pandas there, but we aren't
And some stuff for mozilla-beta that I don't think is mentioned in comment #0.
I'm going to defer to Kim for the rest, as I have no context here.
Attachment #768447 -
Flags: review?(kmoir)
Assignee | ||
Updated•12 years ago
|
Attachment #768447 -
Flags: review?(kmoir) → review+
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 4•12 years ago
|
||
It also includes Ben's earlier patch. I tested it on my dev-master and the builders look correct.
I believe the reftests for mozilla-release should be plain for tegra, none for panda (yet).
Attachment #768522 -
Flags: review?(aki)
Updated•12 years ago
|
Attachment #768522 -
Flags: review?(aki) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #768522 -
Flags: checked-in+
Assignee | ||
Comment 5•12 years ago
|
||
In production
Assignee | ||
Comment 6•12 years ago
|
||
Verified that builders look good on a production master.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•12 years ago
|
||
Thanks, reopened.
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•