884244 - Old Thimble URLs not working

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Laura Hilliger [:epilepticrabbit]]

Old urls don't point to content at all. Error says:

{"__NR_CAUGHT":true}

I've heard JBuck will be looking into this, so I assigned to him. 

A somewhat major snafu for us, as teachtheweb week 8 is supposed to be shipping today and this week we're pointing heavily to the Maker Party invite: https://thimble.webmaker.org/p/la7e/

I'm holding off on emailing those 5000 people, JBuck - ping me when you're in?

Comment 1

[Laura Hilliger [:epilepticrabbit]]

this one was made two days ago: https://thimble.webmaker.org/p/la7e/
this one is, I think, the 6 word memoir made several months ago: https://thimble.webmaker.org/p/l30y/

Talked to POmax and he asked me to include these in the bug.

Comment 2

[David Humphrey (:humph)]

When I hit this, headers indicate I'm seeing a 500:

$ curl -I https://thimble.webmaker.org/p/l30y/
HTTP/1.1 500 Internal Server Error
Content-length: 20
Content-Type: application/json; charset=utf-8
Date: Tue, 18 Jun 2013 14:23:31 GMT
Set-Cookie: thimble.sid=s%3Aj%3A%7B%22_csrf%22%3A%22f-bSgDkdnai0NFgNy5NrecqD%22%7D.PYroJ%2Bme0vB2B%2F5pFjmeYpRLj3k8D%2B53lWCrCgM1phQ; Path=/; Expires=Fri, 19 Jul 2013 14:23:31 GMT; HttpOnly; Secure
Strict-Transport-Security: maxAge=15768000
Vary: Accept-Encoding
X-Powered-By: Express
Connection: keep-alive

Comment 3

[David Humphrey (:humph)]

This is NewRelic's instrumentation error handling stuff:

https://github.com/newrelic/node-newrelic/blob/master/lib/error.js#L99-L129

Comment 4

[David Humphrey (:humph)]

From NR, Pomax sees:

Error: Error: 404 Not Found
 at /var/www/thimble/lib/parameters.js:26:37
 at null.<anonymous> (/var/www/thimble/lib/database.js:110:36)
 at EventEmitter.emit (events.js:95:17)
 at null.<anonymous> (/var/www/thimble/node_modules/sequelize/lib/query-interface.js:291:17)
 at EventEmitter.emit (events.js:117:20)
 at null.<anonymous> (/var/www/thimble/node_modules/sequelize/lib/dialects/mysql/query.js:32:14)
 at Query.Sequence.end (/var/www/thimble/node_modules/mysql/lib/protocol/sequences/Sequence.js:66:24)
 at Query._handleFinalResultPacket (/var/www/thimble/node_modules/mysql/lib/protocol/sequences/Query.js:139:8)
 at Query.EofPacket (/var/www/thimble/node_modules/mysql/lib/protocol/sequences/Query.js:123:8)
 at Protocol._parsePacket (/var/www/thimble/node_modules/mysql/lib/protocol/Protocol.js:169:24)

Comment 5

[David Humphrey (:humph)]

Can we confirm the DBs, DB config, and env setup for this box?  This looks like it can't reach the DB.

Comment 6

[David Humphrey (:humph)]

And, this is:

 /**                                                                                                            
   * parameter used for fetching legacy thimble projects from the
   * special legacy database.         
   * NOTE: this parameter is technically obsolote and will be 
   *       removed at some point in the near future.       
   */
  oldid: function(legacyDatabaseAPI) {
    return function(req, res, next, oldid) {
      legacyDatabaseAPI.findOld(oldid, function(err, result) {
        if (err) { return next( err ); }
        if (!result) { return next( new Error("404 Not Found") ); }  <-----

Comment 7

[David Humphrey (:humph)]

Did the legacy thimble db get brought over with the switch?  It would make sense to see what's happening above if it was missing.

Comment 8

[Pomax]

I suspect this is the case. We need to verify that the old table is in the database, and is using its new name, "LegacyProjects", not the old name "api_page"

Comment 9

[Pomax]

updated DB data request has been filed (as critical) on https://bugzilla.mozilla.org/show_bug.cgi?id=884094

Comment 11

[Kat Braybrooke [:codekat]]

Note: On line 49 of Release Bugs pad, I've added some of the public/community/partner Thimbles that are very high priority for folks - they urgently need these today/tomorrow for workshops + events they're running. 

https://etherpad.mozilla.org/webmaker-2-release-bugs

Will keep watch on here to find out when these are restored.. thanks guys.

Comment 12

[Jon Buckley [:jbuck]]

Old DB imported, we're good to go.

Comment 13

[Laura Hilliger [:epilepticrabbit]]

Just hit a fairly new URL that wasn't transferred in the #teachtheweb community https://thimble.webmaker.org/p/la5h/

thought i should let you know :)

Comment 14

[Pomax]

Better to file a new issue than to reopen landed/fixed issues, unless the fix that caused the ticket to be closed had errors. It's easier to track and solve for the dev team that way. Filed the new issue as https://bugzilla.mozilla.org/show_bug.cgi?id=884882