884358 - Refactor & test GA event tracking/timeout functionality in TabZilla

Status: RESOLVED FIXED

(Websites :: Tabzilla, defect, P3)

Description

[Kohei Yoshino [:kohei]]

+++ This bug was initially created as a clone of Bug #877849 +++

I'll send a pull request soon.

Comment 1

[Kohei Yoshino [:kohei]]

Pull request: https://github.com/mozilla/bedrock/pull/981

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7ca4249da73d37bdfa17d070ac49cee7fff5bfe6
Bug 884358 - Refactor & test GA event tracking/timeout functionality in TabZilla

https://github.com/mozilla/bedrock/commit/9465905c4104b7868bb6d0802ec2934ac6c7c65c
Merge pull request #981 from kyoshino/bug-884358-tabzilla-refactor

Bug 884358 - Refactor & test GA event tracking/timeout functionality in TabZilla

Comment 3

[Kohei Yoshino [:kohei]]

Now live at https://www-dev.allizom.org/en-US/tabzilla/tabzilla.js

Comment 4

[raymond [:retornam] (inactive)]

fixed on dev

Comment 5

[raymond [:retornam] (inactive)]

fixed on stage https://www.allizom.org/en-US/tabzilla/tabzilla.js

Comment 6

[Chris More [:cmore]]

(In reply to Kohei Yoshino [:kohei] from comment #1)
> Pull request: https://github.com/mozilla/bedrock/pull/981

What about the window.gaq comment I made in this parent bug? We are seeing lots of GA calls being dropped when this is not present.

Comment 7

[Chris More [:cmore]]

What does everyone think about abstracting how we do GA event calls with a function so that how we do the coding for tracking is self-contained in a central area?

Comment 8

[Kohei Yoshino [:kohei]]

I'll send a pull request to replace all _gaq.push functions including TabZilla in Bug 880372.

Comment 9

[Kohei Yoshino [:kohei]]

Sorry for the bugspam -- the Target Milestore was set unexpectedly.