Login fails on /reviewers pages

RESOLVED FIXED in 2013-06-20

Status

Marketplace
Reviewer Tools
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wraithan, Assigned: kumar)

Tracking

2013-06-20
Points:
---

Details

STR:
Log out of marketplace
Go to: https://marketplace.firefox.com/reviewers/apps/review/cutedrop
click sign in
sign into persona

Expected:
you sign into the marketplace/reviewer tools

Actual:
you get a persona error
(Reporter)

Updated

4 years ago
Summary: Login fails on pages /reviewers → Login fails on /reviewers pages
I believe the case here is that the frontend is invoking navigator.id.request() with experimental_forceIssuer set to firefoxos.persona.org, but the backend does not supply the same parameter when verifying the assertion.

I come to this conclusion by inspecting HTTP requests, extracting the supplied assertion, and then unpacking it.  This is what I see:

==== cert ====
issuer: firefoxos.persona.org
principal: {"email":"lloyd@hilaiel.com"}
iat: Tue Jun 18 2013 09:23:47 GMT-0600 (MDT) (1371569027424)
exp: Wed Jun 19 2013 09:23:47 GMT-0600 (MDT) (1371655427424)

Note the issuer is firefoxos.persona.org, the only way that this could happen is if forceIssuer were specified on the front end.
Priority: -- → P1
whoops, I didn't test this when fixing bug 873228 (I only tested /developers/). The login JS needs a patch which I am preparing now.
Assignee: nobody → kumar.mcmillan
Target Milestone: --- → 2013-06-20
Fixed https://github.com/mozilla/zamboni/commit/ab80d1d56b13caac52f4cc99e41e2496f6360e6a

You may need to clear cookies for your login to start working.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Duplicate of this bug: 884408
This was just pushed to production. It also affected general DevHub logins.
You need to log in before you can comment on or make changes to this bug.