Closed
Bug 884409
Opened 11 years ago
Closed 11 years ago
Guard against old projects not having thumbnails in embed.js
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
We need to republish all the things.
Assignee | ||
Comment 1•11 years ago
|
||
Republishing won't work so we just have to go with some defensive javascript here.
Summary: Write Republish Script → Guard against old projects not having thumbnails in embed.js
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #764290 -
Flags: review?(jon)
Attachment #764290 -
Flags: review?(david.humphrey)
Updated•11 years ago
|
Attachment #764290 -
Flags: review?(david.humphrey) → review+
Comment 3•11 years ago
|
||
Comment on attachment 764290 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/61 Removing Jon, r+ from me is enough. Land this.
Attachment #764290 -
Flags: review?(jon)
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/30dbae01a0bd30496e28b423574aebd3220d78e9 Fix Bug 884409 - Prevent no thumbnail existing on old project causing breakage. Add in some CSS to prevent preview url showing as that's dead
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•