Guard against old projects not having thumbnails in embed.js

RESOLVED FIXED

Status

Webmaker
Popcorn Maker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mjschranz, Assigned: mjschranz)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We need to republish all the things.
(Assignee)

Comment 1

5 years ago
Republishing won't work so we just have to go with some defensive javascript here.
Summary: Write Republish Script → Guard against old projects not having thumbnails in embed.js
(Assignee)

Comment 2

5 years ago
Created attachment 764290 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/61
Attachment #764290 - Flags: review?(jon)
Attachment #764290 - Flags: review?(david.humphrey)
Attachment #764290 - Flags: review?(david.humphrey) → review+
Comment on attachment 764290 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/61

Removing Jon, r+ from me is enough.  Land this.
Attachment #764290 - Flags: review?(jon)

Comment 4

5 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/30dbae01a0bd30496e28b423574aebd3220d78e9
Fix Bug 884409 - Prevent no thumbnail existing on old project causing breakage. Add in some CSS to prevent preview url showing as that's dead

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.