Publish Module should use project.author for building S3 URLs

RESOLVED WONTFIX

Status

Webmaker
Popcorn Maker
RESOLVED WONTFIX
5 years ago
4 years ago

People

(Reporter: mjschranz, Assigned: mjschranz)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It's using req.session.username but in the event of that not existing it will fail (say mass project republishing). We store that in the author field for projects so we should use this instead.
(Assignee)

Comment 1

5 years ago
Created attachment 764259 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/60

Whoever gets to it first.
Attachment #764259 - Flags: review?(jon)
Attachment #764259 - Flags: review?(david.humphrey)
(Assignee)

Comment 2

5 years ago
The direction changed. This won't actually work/accomplish what we need.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX

Updated

5 years ago
Attachment #764259 - Flags: review?(jon)
Attachment #764259 - Flags: review?(david.humphrey)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.