Closed Bug 884427 Opened 11 years ago Closed 11 years ago

Publish Module should use project.author for building S3 URLs

Categories

(Webmaker Graveyard :: Popcorn Maker, defect)

Product:
Webmaker Graveyard
Component:
Popcorn Maker
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mjschranz, Assigned: mjschranz)

Details

Attachments

(1 file)

https://github.com/mozilla/popcorn.webmaker.org/pull/60
55 bytes, text/x-github-pull-request
Details | Review 
It's using req.session.username but in the event of that not existing it will fail (say mass project republishing). We store that in the author field for projects so we should use this instead.
Whoever gets to it first.
Attachment #764259 - Flags: review?(jon)
Attachment #764259 - Flags: review?(david.humphrey)
The direction changed. This won't actually work/accomplish what we need.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Attachment #764259 - Flags: review?(jon)
Attachment #764259 - Flags: review?(david.humphrey)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: