Closed Bug 884431 Opened 6 years ago Closed 6 years ago

Consistently treat iframe documents as children in the inspector actor

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: dcamp, Assigned: dcamp)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
We treat iframe documents as children for the `children` request but not for childList mutations or numChildren.  This fixes that.
Attachment #764261 - Flags: review?(paul)
Comment on attachment 764261 [details] [diff] [review]
v1

Isn't there a more efficient way to know if there are children? Like checking rawNode.documentElement? (well, maybe that will not work for other types of virtual nodes (anonymous node for example)).
Attachment #764261 - Flags: review?(paul) → review+
Comment on attachment 764261 [details] [diff] [review]
v1

Yeah, I can use contentDocument.
https://hg.mozilla.org/integration/fx-team/rev/deb4d87d1684
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/deb4d87d1684
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.