884480 - Share button for Facebook appears when I'm using MSN

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Verdi [:verdi] Best to slack me]

Attachment: Both facebook and msn widgets show at the same time.

I have two services installed - Facebook and MSN. MSN doesn't seem to use the share feature but it will show the share button when I have Facebook installed. This is confusing. I clicked the share button expecting to vote or promote a page so that it would show up in the MSN sidebar. Instead I got a tool to share it on Facebook even though that service was not being used.

We should make the share button service specific. If the service uses it, it should be shown for that service. If the service does not use the share button we should not show it even if another service is installed that uses it.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Share is orthogonal to the other features of socialapi.  It is designed to allow sharing with any provider regardless of the currently selected primary provider.

Any provider that supports share will show up in that panel, and the last used share provider will always be the selected provider.  When there is more than one provider, a selection is available in margin on the left.  

Granted there is only Facebook ATM, but cliqz is also going to support share, and we have several more lined up.

Comment 2

[Verdi [:verdi] Best to slack me]

Thanks for the explanation. I see now. It makes much more sense if you have both facebook and cliqz installed. Maybe there is some way to make the interaction clearer in the case above?

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to Verdi [:verdi] from comment #2)
> Thanks for the explanation. I see now. It makes much more sense if you have
> both facebook and cliqz installed. Maybe there is some way to make the
> interaction clearer in the case above?

Probably not for Fx23/24 due to the time in the cycle, but improvements do need to be made to some of that.