884499 - Add build flag for building wifi AP/cell tower on Android

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Chenxia Liu [:liuche]]

Bug 866957 adds code to collect wifi AP and cell tower data. I'd like to wrap this in a build flag so we can hook it in with MOZ_DATA_REPORTING (in configure.in), which is used for notifications and some UI components.

Seems like I should just add this to mobile/android/confvars.sh, but flagging Greg (or another build peer) to make sure it wouldn't need to be in mobile/android/config/mozconfigs or something.

Comment 1

[Gregory Szorc [:gps]]

There seems to be an impedance mismatch here. AFAICT the code in bug 866957 is always compiled but only submits depending on the value of a boolean pref.

However, you want the presence of wifi collection code to ensure MOZ_DATA_REPORTING is set which will in turn cause the Firefox on Android background service to display a "Firefox is collecting my data" notification.

Since wifi collection is always enabled in the build config, I *think* what you want is for MOZ_DATA_REPORTING to always be defined for mobile/android. You can do this easily by adding |MOZ_DATA_REPORTING=1| to mobile/android/confvars.sh. Since the already-landed wifi-reporting code isn't protected behind an ifdef, this is probably the best you can do - the build config can't read preferences!

Comment 2

[Kim Moir [:kmoir] ET]

old bug, closing