884507 - [webvtt] SECONDS_TO_MS macro should actually be MS_TO_SECONDS

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

This macro isn't named correctly in VideoUtils.h

Comment 1

[Caitlin Potter (:caitp)]

Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.

Comment 2

[Caitlin Potter (:caitp)]

Oh I guess you added the macro yourself, so it won't hurt anyone.

Comment 3

[Rick Eyre (:reyre)]

Attachment: Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS r=rillian

Comment 4

[Rick Eyre (:reyre)]

Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.

Comment 5

[Caitlin Potter (:caitp)]

I'm a bit shocked that nobody noticed during review.

Comment 6

[Ralph Giles (:rillian)]

(In reply to Caitlin Potter (:caitp) from comment #5)
> I'm a bit shocked that nobody noticed during review.

Me too! :-)

Comment 7

[Rick Eyre (:reyre)]

https://tbpl.mozilla.org/?tree=Try&rev=ad1b508f4045

Comment 8

[Rick Eyre (:reyre)]

Try looks green so I'm marking checkin-needed now.

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a532ecacec0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a532ecacec0