Closed Bug 884507 Opened 10 years ago Closed 10 years ago

[webvtt] SECONDS_TO_MS macro should actually be MS_TO_SECONDS

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: reyre, Assigned: reyre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS r=rillian
1.31 KB, patch
rillian
: review+
Details | Diff | Splinter Review 
This macro isn't named correctly in VideoUtils.h
Assignee: nobody → rick.eyre
Blocks: webvtt
Status: NEW → ASSIGNED
Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.
Oh I guess you added the macro yourself, so it won't hurt anyone.
Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.
I'm a bit shocked that nobody noticed during review.
(In reply to Caitlin Potter (:caitp) from comment #5)
> I'm a bit shocked that nobody noticed during review.

Me too! :-)
Attachment #764340 - Flags: review?(giles) → review+
Try looks green so I'm marking checkin-needed now.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6a532ecacec0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.