This macro isn't named correctly in VideoUtils.h
Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.
Oh I guess you added the macro yourself, so it won't hurt anyone.
Created attachment 764340 [details] [diff] [review] Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS r=rillian
Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.
I'm a bit shocked that nobody noticed during review.
(In reply to Caitlin Potter (:caitp) from comment #5) > I'm a bit shocked that nobody noticed during review. Me too! :-)
Try looks green so I'm marking checkin-needed now.