The default bug view has changed. See this FAQ.

[webvtt] SECONDS_TO_MS macro should actually be MS_TO_SECONDS

RESOLVED FIXED in mozilla24

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: reyre, Assigned: reyre)

Tracking

(Blocks: 1 bug)

Trunk
mozilla24
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This macro isn't named correctly in VideoUtils.h
(Assignee)

Updated

4 years ago
Assignee: nobody → rick.eyre
Blocks: 629350
Status: NEW → ASSIGNED
Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.
Oh I guess you added the macro yourself, so it won't hurt anyone.
(Assignee)

Comment 3

4 years ago
Created attachment 764340 [details] [diff] [review]
Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS  r=rillian
Attachment #764340 - Flags: review?(giles)
(Assignee)

Comment 4

4 years ago
Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.
I'm a bit shocked that nobody noticed during review.
(In reply to Caitlin Potter (:caitp) from comment #5)
> I'm a bit shocked that nobody noticed during review.

Me too! :-)
Attachment #764340 - Flags: review?(giles) → review+
(Assignee)

Comment 7

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=ad1b508f4045
(Assignee)

Comment 8

4 years ago
Try looks green so I'm marking checkin-needed now.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a532ecacec0
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6a532ecacec0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.