Last Comment Bug 884507 - [webvtt] SECONDS_TO_MS macro should actually be MS_TO_SECONDS
: [webvtt] SECONDS_TO_MS macro should actually be MS_TO_SECONDS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla24
Assigned To: Rick Eyre (:reyre)
:
Mentors:
Depends on:
Blocks: webvtt
  Show dependency treegraph
 
Reported: 2013-06-18 12:43 PDT by Rick Eyre (:reyre)
Modified: 2013-06-21 07:46 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS r=rillian (1.31 KB, patch)
2013-06-18 12:53 PDT, Rick Eyre (:reyre)
giles: review+
Details | Diff | Splinter Review

Description Rick Eyre (:reyre) 2013-06-18 12:43:47 PDT
This macro isn't named correctly in VideoUtils.h
Comment 1 Caitlin Potter (:caitp) 2013-06-18 12:50:57 PDT
Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.
Comment 2 Caitlin Potter (:caitp) 2013-06-18 12:52:46 PDT
Oh I guess you added the macro yourself, so it won't hurt anyone.
Comment 3 Rick Eyre (:reyre) 2013-06-18 12:53:27 PDT
Created attachment 764340 [details] [diff] [review]
Bug 884507 - Change SECOND_TO_MS macro to be named MS_TO_SECONDS  r=rillian
Comment 4 Rick Eyre (:reyre) 2013-06-18 12:54:57 PDT
Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.
Comment 5 Caitlin Potter (:caitp) 2013-06-18 12:56:06 PDT
I'm a bit shocked that nobody noticed during review.
Comment 6 Ralph Giles (:rillian) on PTO until August 15 2013-06-18 12:59:08 PDT
(In reply to Caitlin Potter (:caitp) from comment #5)
> I'm a bit shocked that nobody noticed during review.

Me too! :-)
Comment 7 Rick Eyre (:reyre) 2013-06-18 13:05:59 PDT
https://tbpl.mozilla.org/?tree=Try&rev=ad1b508f4045
Comment 8 Rick Eyre (:reyre) 2013-06-19 08:44:26 PDT
Try looks green so I'm marking checkin-needed now.
Comment 9 Ralph Giles (:rillian) on PTO until August 15 2013-06-19 08:49:34 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a532ecacec0
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-06-20 07:09:10 PDT
https://hg.mozilla.org/mozilla-central/rev/6a532ecacec0

Note You need to log in before you can comment on or make changes to this bug.