Closed Bug 884507 Opened 6 years ago Closed 6 years ago
_TO _MS macro should actually be MS _TO _SECONDS
This macro isn't named correctly in VideoUtils.h
Assignee: nobody → rick.eyre
Status: NEW → ASSIGNED
Hah, good catch. I don't see anyone else using the macro on MXR, might want to double check with grep to be sure it doesn't break anything renaming it.
Oh I guess you added the macro yourself, so it won't hurt anyone.
Yeah, I think at the time we were all really confused about the times, heh. Now with the tests it's more clear what's happening.
I'm a bit shocked that nobody noticed during review.
(In reply to Caitlin Potter (:caitp) from comment #5) > I'm a bit shocked that nobody noticed during review. Me too! :-)
Attachment #764340 - Flags: review?(giles) → review+
Try looks green so I'm marking checkin-needed now.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.