[MMS] "To:" field may be truncated for some localizations

RESOLVED FIXED

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jugglinmike, Assigned: jugglinmike)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In the Recipients list, the text of the string "To:" will be truncated for localizations with longer strings. (Cause: the field has a hard-coded width.)
(Assignee)

Comment 1

4 years ago
Created attachment 764341 [details] [diff] [review]
Support variable-width "To:" field

This work was originally submitted as part of the patch for Bug 883813. I've separated out the changes relating to the "To:" field and incorporated Julien's feedback.
Attachment #764341 - Flags: review?(felash)
(Assignee)

Comment 2

4 years ago
Applying for "leo+".

Motivation: This bug will obscure part of the "Compose" interface for some localizations.

Risk: Low. These are HTML and CSS changes only.
blocking-b2g: --- → leo?
If we don't use leo+ now, this will come later to bite us. For example, in French, we get "Po..." instead of "Pour :", because the english "To:" is so small.
(In reply to Julien Wajsberg [:julienw] from comment #3)
> If we don't use leo+ now, this will come later to bite us. For example, in
> French, we get "Po..." instead of "Pour :", because the english "To:" is so
> small.

I just switch my iPhone to French and it replaced "To:" with "À:" (I apologize for using another platform to compare)
I've put the "Pour :" myself in the french translation to make a case, I don't know what the final translation will be.
(Assignee)

Comment 6

4 years ago
(In reply to Julien Wajsberg [:julienw] from comment #5)
> I don't know what the final translation will be.

That is the most important point. Even if it is "À:" today, there's no reason why it couldn't be "Pour:" tomorrow. And who knows how long the text might be in other translations?
I wasn't making a case for or against either.
Comment on attachment 764341 [details] [diff] [review]
Support variable-width "To:" field

Review of attachment 764341 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that change

::: apps/sms/index.html
@@ +143,5 @@
>          <form role="search" id="messages-compose-form" class="bottom messages-compose-form" data-message-type="sms">
>            <button id="messages-attach-button" class="icon icon-attachment">Attachment</button>
>            <button id="messages-send-button" disabled data-l10n-id="send" type="submit">Send</button>
>            <!-- The <br> is needed because of 414223, which is a WONTFIX. It's just because of how contentEditable works. https://bugzilla.mozilla.org/show_bug.cgi?id=414223 -->
> +          <div id="messages-input" contentEditable="true" name="message" data-l10n-id="composeMessage"><br></div>

revert this change please
Attachment #764341 - Flags: review?(felash) → review+
(Assignee)

Comment 9

4 years ago
Landed at commit 4b1359c18031b20eac667952a9e50b3729fbaa9e

Thanks for the review, Julien!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
blocking-b2g: leo? → leo+
Uplifted 4b1359c18031b20eac667952a9e50b3729fbaa9e to:
v1-train: c52a0694112ced6e3f41af65be5645223b9b7ad7
status-b2g18: --- → fixed
was merged in 1.1hd (see bug 883813 comment 7)

1.1hd: c52a0694112ced6e3f41af65be5645223b9b7ad7
status-b2g-v1.1hd: --- → fixed

Comment 12

4 years ago
The 'To' field in MMS app is not truncated anymore.
Verified with 4 different languages - Portuges(do Brasil), Romanian, Spanish and 
dutch set on device

Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
RIL Version: 01.01.00.019.164
status-b2g18: fixed → verified
You need to log in before you can comment on or make changes to this bug.