884514 - Hide windows from a11y layer when lockscreen is active

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Eitan Isaacson [:eeejay]]

There has been a regression from this commit:
https://github.com/mozilla-b2g/gaia/commit/ec3e9d717443735f0ad04c3ff5e3ccd0ec2214db

Reintroducing that will not suffice. For one, we should be hiding all app windows, not just the homescreen (plus, that changeset was before oop iframes). Second, we can't just set iframes visibility to hidden, because audio apps will get muted when the lockscreen engages.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Hide windows when lockscreen is active.

Changing the style of the app iframes won't work well because it will interfere with the way that audio apps work. So we need to use aria-hidden.

Comment 2

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/09e4e21f31dbd3b4a85a1919d0e28487f604e322

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 764344 [details] [diff] [review]
Hide windows when lockscreen is active.

Review of attachment 764344 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know the meaning of this change.