Fix UI details on Events / Add an Event

RESOLVED FIXED

Status

Webmaker
Events
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: cassiemc, Assigned: daleee)

Tracking

Details

(Whiteboard: designQA, frontend, postfest)

Attachments

(1 attachment, 1 obsolete attachment)

48 bytes, text/x-github-pull-request
inactivate account for kate
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 years ago
In the Add an Events section of the /events page:

* on the submit your event button, use > instead of + icon
* on event begins and ends dropdowns, clicking on chevron button when the calendar is open should collapse the calendar.
* why include an image hyperlink button in text editor when there is "upload an image" functionality? Can this be removed?
* error - when fields highilght pink with the red border - the red border does not exactly match the button. eg. http://cl.ly/PjgB
(Assignee)

Updated

5 years ago
Assignee: hike → nobody
(Assignee)

Comment 1

4 years ago
These two points are still relevant:
* on event begins and ends dropdowns, clicking on chevron button when the calendar is open should collapse the calendar.
* why include an image hyperlink button in text editor when there is "upload an image" functionality? Can this be removed?

But the error field stuff is beyond our control and varies by browser.
Whiteboard: designQA → designQA, frontend, postfest

Updated

4 years ago
Assignee: nobody → dale
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8340027 [details] [review]
https://github.com/mozilla/webmaker.org/pull/527

https://github.com/mozilla/webmaker.org/pull/527

Gavin/Kate: Neither of you are in today so I'm flagging both of you for review. Whichever of you has the time to look at this first... prease do :)
Attachment #8340027 - Flags: review?(kate)
Attachment #8340027 - Flags: review?(gavin)
Comment on attachment 8340027 [details] [review]
https://github.com/mozilla/webmaker.org/pull/527

This doesn't really work because if you click on the arrow drop down button, then click somewhere else (say the input next to it), then click back on the original drop down, the calendar just flickers on and off.

You might want to consider using a classname check or something instead of a private var.
Attachment #8340027 - Flags: review?(kate) → review-
(Assignee)

Comment 4

4 years ago
Comment on attachment 8340027 [details] [review]
https://github.com/mozilla/webmaker.org/pull/527

Removing Gavin from review queue.
Attachment #8340027 - Flags: review?(gavin)
(Assignee)

Comment 5

4 years ago
Created attachment 8341892 [details] [review]
Code Review 2

https://github.com/mozilla/webmaker.org/pull/527

Now using CSS classname instead of internal variable... although the end effect seems the same? Also changed timepicker to use class name as well.
Attachment #8340027 - Attachment is obsolete: true
Attachment #8341892 - Flags: review?(kate)
Attachment #8341892 - Flags: review?(kate) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.