Closed Bug 884564 Opened 8 years ago Closed 8 years ago
Block Frame::Create Continuation For(). (it's unnecessarily virtual & has always-NS _OK nsresult rv)
nsBlockFrame's method "CreateContinuationFor" is virtual, but it's never overridden (and it's not overriding anything): http://mxr.mozilla.org/mozilla-central/search?string=CreateContinuationFor%28 Also, it returns type nsresult, but it only ever returns NS_OK -- so we can drop the nsresult return value and just make it directly return its boolean outparam.
Component: Layout → Layout: Block and Inline
OS: Linux → All
Hardware: x86_64 → All
This patch: a) Removes the nsresult rv, and makes us just directly return a bool b) Removes the bool in one caller (the second one), because it's unused there c) Drops 'frameType' from the contextual code in that same caller, so that the "// Create a continuation" comment is actually next to the CreateContinuationFor() call.
Attachment #764412 - Flags: review?(bzbarsky)
Comment on attachment 764412 [details] [diff] [review] fix v1 r=me
Attachment #764412 - Flags: review?(bzbarsky) → review+
Status: NEW → ASSIGNED
I pushed a followup to fix an end-of-line space character in CreateContinuationFor, while I'm in the neighborhood: https://hg.mozilla.org/integration/mozilla-inbound/rev/0414d4228e85
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.