884564 - Simplify nsBlockFrame::CreateContinuationFor(). (it's unnecessarily virtual & has always-NS_OK nsresult rv)

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Daniel Holbert [:dholbert] (on leave until Dec 1)]

nsBlockFrame's method "CreateContinuationFor" is virtual, but it's never overridden (and it's not overriding anything):
 http://mxr.mozilla.org/mozilla-central/search?string=CreateContinuationFor%28

Also, it returns type nsresult, but it only ever returns NS_OK -- so we can drop the nsresult return value and just make it directly return its boolean outparam.

Comment 1

[Daniel Holbert [:dholbert] (on leave until Dec 1)]

Attachment: fix v1

This patch:
 a) Removes the nsresult rv, and makes us just directly return a bool
 b) Removes the bool in one caller (the second one), because it's unused there
 c) Drops 'frameType' from the contextual code in that same caller, so that the "// Create a continuation" comment is actually next to the CreateContinuationFor() call.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 764412 [details] [diff] [review]
fix v1

r=me

Comment 3

[Daniel Holbert [:dholbert] (on leave until Dec 1)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/416252ef9d1e

Comment 4

[Daniel Holbert [:dholbert] (on leave until Dec 1)]

I pushed a followup to fix an end-of-line space character in CreateContinuationFor, while I'm in the neighborhood:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/0414d4228e85

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/416252ef9d1e
https://hg.mozilla.org/mozilla-central/rev/0414d4228e85