Simplify nsBlockFrame::CreateContinuationFor(). (it's unnecessarily virtual & has always-NS_OK nsresult rv)

RESOLVED FIXED in mozilla24

Status

()

Product:
Core
Component:
Layout: Block and Inline
Type:
defect
Status:
RESOLVED FIXED
Opened:
6 years ago
Updated:
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Version:
Trunk
Target:
mozilla24
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix v1
5.24 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
nsBlockFrame's method "CreateContinuationFor" is virtual, but it's never overridden (and it's not overriding anything):
 http://mxr.mozilla.org/mozilla-central/search?string=CreateContinuationFor%28

Also, it returns type nsresult, but it only ever returns NS_OK -- so we can drop the nsresult return value and just make it directly return its boolean outparam.
Component: Layout → Layout: Block and Inline
OS: Linux → All
Hardware: x86_64 → All
Posted patch fix v1 — — Splinter Review 
This patch:
 a) Removes the nsresult rv, and makes us just directly return a bool
 b) Removes the bool in one caller (the second one), because it's unused there
 c) Drops 'frameType' from the contextual code in that same caller, so that the "// Create a continuation" comment is actually next to the CreateContinuationFor() call.
Attachment #764412 - Flags: review?(bzbarsky)
Comment on attachment 764412 [details] [diff] [review]
fix v1

r=me
Attachment #764412 - Flags: review?(bzbarsky) → review+
Flags: in-testsuite-
I pushed a followup to fix an end-of-line space character in CreateContinuationFor, while I'm in the neighborhood:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/0414d4228e85
https://hg.mozilla.org/mozilla-central/rev/416252ef9d1e
https://hg.mozilla.org/mozilla-central/rev/0414d4228e85
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.