Closed Bug 884595 Opened 8 years ago Closed 8 years ago

[Camera] Additional lazy loading for load performance

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=3 s= u=])

Attachments

(1 file)

I think there's a few more things we can lazy load on camera startup including localization libraries and potentially dom nodes.
Whiteboard: c= p=3;
Keywords: perf
Whiteboard: c= p=3; → c= p=3 ,
Comment on attachment 765018 [details]
Github pull request pointer

Hi Etienne,

I think we will see a slight speed-up in some apps if we lazy-load the localization. In this pull request I've moved lazy_l10n into shared and use it in the camera app. Would you be up for reviewing this?
Attachment #765018 - Flags: review?(etienne)
Comment on attachment 765018 [details]
Github pull request pointer

r- for now since this breaks the call screen.

But it's cool to take advantage of this in the camera app too!
Attachment #765018 - Flags: review?(etienne) → review-
Comment on attachment 765018 [details]
Github pull request pointer

Etienne - comments addressed and tested, please take a look when you have a chance:)
Attachment #765018 - Flags: review- → review?(etienne)
Comment on attachment 765018 [details]
Github pull request pointer

definitely better :)
Attachment #765018 - Flags: review?(etienne) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/f0b02f84cf116ca8888f80e8b4ce0a3ccf7efd3e

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 901463
Blocks: 896833
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: c= p=3 , → [c= p=3 s= u=]
You need to log in before you can comment on or make changes to this bug.