884638 - 'dbg close' errors when toolbox is already closed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Anton Kovalyov (:anton)]

Steps to reproduce:

1. Close toolbox.
2. Open GCLI.
3. Run 'dbg close'

It will error, it shouldn't.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Make 'dbg close' do nothing when toolbox is closed

Patch similar to the one for 'profiler close'

Comment 2

[Anton Kovalyov (:anton)]

Attachment: Make 'dbg close' do nothing when toolbox is closed

Previous patch had a small typo.

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 764517 [details] [diff] [review]
Make 'dbg close' do nothing when toolbox is closed

Review of attachment 764517 [details] [diff] [review]:
-----------------------------------------------------------------

I think my r+ can do for dcamp too.

The margin for improvement in these tests is small to non-existant, but 2 facts that might not be obvious about helpers:

* helpers.audit returns a promise that is only completed when it is totally done
* There is a 'post' property that lets you run tests to check that everything worked ok
  So ...

    return helpers.check([{
      setup: 'profiler close',
      exec: {},
      post: function() {
        return getPromiseFulfilledWhenTheProfilerCloses()
      }
    }]);

The need to use events makes it hard to use this style, but I thought it was worth noting in case it wasn't obvious.

Comment 4

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/437caa035564

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/437caa035564