Closed Bug 884638 Opened 6 years ago Closed 6 years ago

'dbg close' errors when toolbox is already closed

Categories

(DevTools :: Debugger, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: anton, Assigned: anton)

Details

Attachments

(1 file, 1 obsolete file)

Steps to reproduce:

1. Close toolbox.
2. Open GCLI.
3. Run 'dbg close'

It will error, it shouldn't.
Patch similar to the one for 'profiler close'
Attachment #764509 - Flags: review?(jwalker)
Attachment #764509 - Flags: review?(dcamp)
Previous patch had a small typo.
Attachment #764509 - Attachment is obsolete: true
Attachment #764509 - Flags: review?(jwalker)
Attachment #764509 - Flags: review?(dcamp)
Attachment #764517 - Flags: review?(jwalker)
Attachment #764517 - Flags: review?(dcamp)
Comment on attachment 764517 [details] [diff] [review]
Make 'dbg close' do nothing when toolbox is closed

Review of attachment 764517 [details] [diff] [review]:
-----------------------------------------------------------------

I think my r+ can do for dcamp too.

The margin for improvement in these tests is small to non-existant, but 2 facts that might not be obvious about helpers:

* helpers.audit returns a promise that is only completed when it is totally done
* There is a 'post' property that lets you run tests to check that everything worked ok
  So ...

    return helpers.check([{
      setup: 'profiler close',
      exec: {},
      post: function() {
        return getPromiseFulfilledWhenTheProfilerCloses()
      }
    }]);

The need to use events makes it hard to use this style, but I thought it was worth noting in case it wasn't obvious.
Attachment #764517 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/mozilla-central/rev/437caa035564
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Attachment #764517 - Flags: review?(dcamp)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.