Closed Bug 884679 Opened 6 years ago Closed 6 years ago

Contacts: Remove devtools/Console.jsm from ContactsDB.jsm

Categories

(Core :: DOM: Device Interfaces, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: gwagner, Assigned: bkelly)

References

Details

(Whiteboard: c= s=2013.06.28 p=2 ,)

Attachments

(1 file)

We shouldn't load the console.jsm file when we load the contactsDB. Our contacts startup is already slow enough :)
ContactDB (via ContactService) is loaded by shell.js, so Console.jsm will be loaded once at startup. Is that really a problem?
What is the preferred logging mechanism?  I saw both dump() and Cu.reportError() in use.  This led me to ask on #developers which pointed me towards the Console.jsm which apparently is the replacement for Cu.reportError().
We usually ask people for the logcat and I am not sure if the console log gets dumped to logcat. It's also not well supported on b2g because of global object merging and we had to back out bug 879228 because of this.
Just use dump.
Assignee: nobody → bkelly
Comment on attachment 764946 [details] [diff] [review]
Output warning using dump() instead of Console.jsm

Review of attachment 764946 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #764946 - Flags: review?(anygregor) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/085dd9b723d0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Whiteboard: c= s=2013.06.28 p=2 ,
You need to log in before you can comment on or make changes to this bug.