884694 - 'Tap here to activate plugin' UI is displayed although the plugin option is set to "Enabled"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Build: Firefox for Android 24.0a1 (2013-06-18)
Device: LG Nexus 4
OS: Android 4.2.2

Set plugins to 'Enabled'
Steps to reproduce:
Go to http://www.intel.com/museumofme/

Expected results:
- You should see flash plugins without having to tap

Actual results:
- The message: 'Tap here to activate plugin' appears as if plugins were set on 'Tap to Play'

Comment 1

[Aaron Train [:aaronmt]]

Please find a regression range.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

regressionwindow-wanted:
1.mozilla central:
good build: 11-06-2013
bad build:  12-06-2013

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=86413e921d5d&tochange=0414d6d0f60d

2.inbound:
good build: 1370961674
bad build:  1370962937

pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8ac5d1f98b21&tochange=5ef49706a56a

Comment 3

[Benjamin Smedberg]

Is there a site-specific permission for that site? Previously we only checked site-specific permissions if a plugin was set to "click-to-enable". Now we honor site-specific permissions for enabled plugins as well. So if you had a site-specific click-to-activate permission for intel.com, that will override the normal setting.

Does fennec have an about:permissions or something like that? Does this happen on other sites?

Comment 4

[Aaron Train [:aaronmt]]

It doesn't look like any site permissions are set for that URL. 

I also see this on other URLs such as: http://www.kace.com/demo/flashdemo and http://www.sonycreativesoftware.com/products/sdml/sdml.asp

They are all prompting for tap to activate despite our preference set as enabled.

Comment 5

[Benjamin Smedberg]

Attachment: Fix the android pref settings, rev. 1

This was written blind, but it's pretty straightforward. The plugins.click_to_play preference no longer does anything, and so you should be modifying the plugin.default.state preference instead.

This will mean that users who currently have "always activate" set will need to make that change again, or we'll need to migrate the preference on upgrade. I'm not sure whether that's important or the best place to accomplish that.

Comment 6

[:Margaret Leibovic]

Comment on attachment 764820 [details] [diff] [review]
Fix the android pref settings, rev. 1

This looks good, and I confirmed it works as expected.

Comment 7

[:Margaret Leibovic]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)

> This will mean that users who currently have "always activate" set will need
> to make that change again, or we'll need to migrate the preference on
> upgrade. I'm not sure whether that's important or the best place to
> accomplish that.

I'm also not sure what we should do here. Off the top of my head, I don't know if we have a place where we do gecko pref migrations. If it's not too difficult to implement, I think it would be worthwhile to migrate the pref.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa4eb6a7a300

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a1(2013-06-21) 
Device: Samsung Galaxy Nexus
OS: Android 4.1.1