884698 - [Buri][Email]The synchronize option in IMAP account does not work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, enhancement)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.131
 Firefox os  v1.0.1
 Mozilla build ID:20130606070202
 
 
 DEFECT DESCRIPTION:
 The synchronize option in IMAP account does not work
 
  REPRODUCING PROCEDURES:
 1.Create an imap email account;
 2.Enter setting-->the IMAP account-->Synchronize;
 3.The Synchronize option have "Automatic,1 day,3 day..";
 4.Change the options and to receive emails,but the setting does not work-->ko
 
 Similar to the PR:412881:The PR is for Synchronize option by exchange account
 
  EXPECTED BEHAVIOUR:
 The options can work well
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

For IMAP this option currently affects the retention logic's decision of which messages to retain when purging messages.  The option also affects the disabled functionality used for periodic synchronization.  Periodic synchronization is targeted to be re-enabled and enhanced in v1.2.

It's not clear from the expected behaviour of "The options can work well" what assumptions are being made about how IMAP synchronization works or could work.  Could you please clarify?

Comment 2

[clwu]

(In reply to Andrew Sutherland (:asuth) from comment #1)
> For IMAP this option currently affects the retention logic's decision of
> which messages to retain when purging messages.  The option also affects the
> disabled functionality used for periodic synchronization.  Periodic
> synchronization is targeted to be re-enabled and enhanced in v1.2.
> 
> It's not clear from the expected behaviour of "The options can work well"
> what assumptions are being made about how IMAP synchronization works or
> could work.  Could you please clarify?

REPRODUCING PROCEDURES:
3.The Synchronize option have "Automatic,1 day,3 day..";
==> If select "1 day",it should display the recent one day mails, but the
mails before one day are always exist.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to clwu from comment #2)
> REPRODUCING PROCEDURES:
> 3.The Synchronize option have "Automatic,1 day,3 day..";
> ==> If select "1 day",it should display the recent one day mails, but the
> mails before one day are always exist.

Ah.  The synchronization mechanisms for ActiveSync and IMAP are very different.  I've tried to provide a brief overview at:
https://wiki.mozilla.org/Gaia/Email/Implementation/MailSynchronization

As it relates to this bug; we already have the messages for older days because of our sync mechanism, so there's no reason for us to not show them.  It is debatable as to whether we should be using the same "Synchronize" label for IMAP as we are for ActiveSync; this may be covered on other bugs by our discussion of how to expose various synchronization-related settings.

I'm going to leave this bug here as-is to serve as a place-holder with the hope that we are able to mark this resolved once we implement those other sync settings for v1.2.  cc'ing :robmac in case he wants to roll this as input into revised UX wire-frames for that.

Comment 4

[Dylan Oliver [:doliver]]

Triage: This bug has been added to the v1.2 backlog but is not blocking release

Comment 6

[psingapati]

As discussed on IRC with asuth, The right solution for this bug is hiding synchronize setting for IMAP accounts.

Working on this issue, will upload patch soon.

Comment 7

[psingapati]

Attachment: Pointer to PR

Pointer to Pull request to gaia/master
https://github.com/mozilla-b2g/gaia/pull/11824

Please review

Comment 8

[psingapati]

Raised PR for v1-train

https://github.com/mozilla-b2g/gaia/pull/11825

Please check

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 797042 [details]
Pointer to PR

This works great; thanks for the fix!

r=asuth conditional on fixing the lint error.  There needs to be a space after 'if' and before '('.  If you have merge privileges, feel free to merge after making the change and squashing your commit.  If not, I can land it for you once you've made that change.

I'm fine on the v1-train landing too; can you mark this leo+ so we have permission to land it?  Or does someone else need to do that?

Comment 10

[psingapati]

Thanks for r=asuth.

I have fixed LINT error and pushed the branch again.

I do not have permissions (also do not know how to merge). Can you please merge it on both master and v1train (marked as leo+).

Thanks.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/11824
https://github.com/mozilla-b2g/gaia/commit/c8e17c9c161464335bc6005ae0b57ec819c669a9

landed on gaia/v1-train:
https://github.com/mozilla-b2g/gaia/pull/11825
https://github.com/mozilla-b2g/gaia/commit/cd5ea46e3777ac0e995f346432b67ebcc5267792

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: cd5ea46e3777ac0e995f346432b67ebcc5267792
v1.1.0hd: 4145829960a693eed3a4dbb2dac6cb02e1e0dfcd