884703 - [keyboard] A and L keys are the wrong size when keyboard goes to landscape mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

Attachment: screenshot showing wrong size A and L keys

Steps to reproduce:

1) Use a master build. I don't think this bug affects v1-train

2) Open the browser

3) Tap in the URL bar so that the keyboard appears

4) Rotate the phone into landscape mode

5) When the keyboard converts to its landscape layout, notice that the A and L keys are too narrow.

I think this is a regression caused by bug 876598.

Comment 1

[David Flanagan [:djf]]

Setting needinfo for Jan and Rudy: do either of you want to take this bug?

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, I will take a look if Jan does not beat me to it.

Comment 3

[David Flanagan [:djf]]

Note that bug 882954 is also a regression caused by the same bug. I've fixed that bug and have a patch awaiting Jan's review, so work on this bug should probably also take the patch on bug 882954 into account.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

When rotating we only apply resizeUI and don't re-render the whole UI. Therefore the style.width property on a visual key is still set and we get the value derived from that back in `visualKey.offsetWidth`. This patch removes the width before resizing the keys. The reason I don't do it inline is because it triggers a reflow for every key we apply this to, so rather do that at the beginning.

Tests for this change are in https://github.com/mozilla-b2g/gaia/pull/10532.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 767125 [details] [diff] [review]
Patch

Looks pretty good to me, r+.
Thanks for your support on looking into keyboard issues.

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

You're welcome. Landed in https://github.com/mozilla-b2g/gaia/commit/4ff08488db95be91f7540d8ed156da320ef8196c