884744 - Remove CallExpression as a left-leaf of AttributeExpression

Status: RESOLVED FIXED

(L20n :: General, defect, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

For 1.0 we want to restrict the return values of Macro to String.

That means that macro should never return an entity so an expression like this: 

macro()::attr1

Since we already have guards on the type of the base expression for AttributeExpression, Stas suggested to remove the CallExpression from this and throw on parsing.

If we ever revisit this and will want to let macro return entity, we'll just readd this.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch against js

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch against py

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch against js

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 764675 [details] [diff] [review]
patch against js

Review of attachment 764675 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/lib/parser.js
@@ +528,4 @@
>        '<id[x.y::["z"]] "foo">',
>        '<id[x::y::["z"]] "foo">',
>        '<id[x::[1 "foo">',
> +      '<id[x()::[1]] "foo">',

replace [1] with a string?

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 764673 [details] [diff] [review]
patch against py

Review of attachment 764673 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/format/lol/parser.py
@@ +639,5 @@
> +              '<id[x::y::z] "foo">',
> +              '<id[x.y::["z"]] "foo">',
> +              '<id[x::y::["z"]] "foo">',
> +              '<id[x::[1 "foo">',
> +              '<id[x()::[1]] "foo">',

idem

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/1c946d23a3576e3efbeddf652c59c5c9e249ab1f
https://github.com/l20n/python-l20n/commit/71989e697eb28626aa7100f21e39cca0f0a50427