Closed Bug 884748 Opened 8 years ago Closed 8 years ago

Make nsTouchEvent::touches store Touch instead of nsIDOMTouch

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #764679 - Flags: review?(dzbarsky)
Comment on attachment 764679 [details] [diff] [review]
Patch v1

Review of attachment 764679 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMTouchEvent.cpp
@@ +19,1 @@
>  {

I think for nested templates we don't put a space after the first <
Same thing everywhere else.

@@ +184,5 @@
>        // for touchend/cancel events, don't append to the target list if this is a
>        // touch that is ending
>        if ((mEvent->message != NS_TOUCH_END &&
>             mEvent->message != NS_TOUCH_CANCEL) || !touches[i]->mChanged) {
> +        if (touches[i]->mTarget == mEvent->originalTarget) {

Target().  I have a patch somewhere that moves these variables from nsIDOMTouch to Touch, and we'll want them to be protected.

::: layout/base/nsPresShell.cpp
@@ +5864,1 @@
>    if (!node) {

Target().  Same everywhere else.

::: widget/nsGUIEvent.h
@@ +34,1 @@
>  

This seems unfortunate because it will be included all over the tree.  Can you move the ctor/dtor out of line?
Attachment #764679 - Flags: review?(dzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/12acd6ba4220
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.